search

emilyploszaj / emi

A featureful and accessible item and recipe viewer
MIT License
220 stars 46 forks source link

Invisible ingredients in some recipes #534

Closed CestQuoiUnPseudo closed 1 month ago

CestQuoiUnPseudo commented 1 month ago

Playing Monifactory Alpha 0.2.4, which is using EMI 1.1.6 1.20.1 forge. I've been seeing the problem on versions of Moni that uses EMI 1.1.6, but not in alpha 0.2.2, when it used EMI 1.1.4.

Here's a copy of the issue as reported in ThePansmith/Monifactory:

image I first saw it on this recipe However the usual recipe work: glass + oxygen. Dunno if it's just my install I also saw the same "invisible glass" problem on other recipes. image Centrifuging recipe for SiO2, MgO, CaO, Gold, Al2O3 and Tantalite image Drilling fluid recipe. No other ways to make it, could be a game-breaking problem. image Ore washer, Impure pile of Salt into Salt Most Ore Washer recipes actually. Maybe it's a special brand of water?

Pansmith (lead Monifactory dev) answered that those weren't custom recipes and those were either GTCEu or EMI issues. I've been seeing a problem in the newest version of EMI and i'm assuming the problem might be with this mod.

Please let me know if you need more information

emilyploszaj commented 1 month ago

GT is invasive and modifies EMI in ways where I am unable to debug this issue, you'll have to rely on them to figure this out.

CestQuoiUnPseudo commented 1 month ago

Thanks for the answer, gonna check with them

screret commented 1 month ago

GT is invasive and modifies EMI in ways where I am unable to debug this issue, you'll have to rely on them to figure this out.

we fixed that, remember?

emilyploszaj commented 1 month ago

I didn't know the extent of the changes, at least in this case EMI doesn't show these issues outside of gt recipes so I can't really debug it properly, it seems very likely it's on gt's end

screret commented 1 month ago

according to your tag manager, the minecraft:block/forge:glass tag is empty? this issue was introduced here which leads me to believe it isn't actually a GT issue. image

the loading system is checking for tag collisions and preferring the MC tag, but the getRawValues method doesn't do that, so it ends up returning an empty tag. EmiTags#reloadTags calls #consolodateTags -> #betterTag which ends up picking the MC tag over the duplicate forge one.