emilyploszaj / emi

A featureful and accessible item and recipe viewer
MIT License
220 stars 45 forks source link

calling EmiIngredient.of(tag, amount) with a conflicting tag makes an empty ingredient instead of one referencing the vanilla one #554

Closed screret closed 2 weeks ago

screret commented 1 month ago

the loading system is checking for tag collisions and preferring the MC tag, but the getRawValues method doesn't do that, so it ends up returning an empty tag. This is then passed down the call chain to EmiIngredient.of(TagKey<Item>, long) and creates an empty ingredient with only an amount.

EmiTags#reloadTags calls EmiTags#consolodateTags -> EmiTags#betterTag which ends up picking the MC tag over the duplicate forge one, but EmiTags#getRawValues doesn't do this.

originally at https://github.com/emilyploszaj/emi/issues/534#issuecomment-2133441042 .

emilyploszaj commented 2 weeks ago

This has been adjusted in 1.1.7 and should no longer occur.