emilyploszaj / emi

A featureful and accessible item and recipe viewer
MIT License
220 stars 46 forks source link

[1.20.4] - Immersive Engineering Compatability Issues #605

Open AriaElidove opened 5 days ago

AriaElidove commented 5 days ago

There are a few issues regarding Immersive Engineering and Just Enough Items as well as EMI that simply do not happen without EMI. There may be more, there may be less, I would not know anything beyond what I have found and am listing below.


1) Invalid Enchantments

EMI registers that certain non-enchantable items can be enchanted. A couple examples of this are the Collapsible Glider and Wirecutters in Immersive Engineering. EMI assumes that the Collapsible Glider can be enchanted with generic enchantments, such as Mending, Unbreaking, and Curse of Vanishing & Binding, but this is not the case when one would attempt to do so via anvil. Just Enough Items, when alone with Immersive Engineering, will show that the enchantment is not true.


With EMI image


Without EMI (Note the lack of an Anvil) image


2) Custom Recipes

Immersive Engineering has many different custom recipes, but none are registered with EMI itself. These are instead registered with Just Enough Items. When EMI is included with these two mods, it causes Immersive Engineering's recipes to break. Certain information and values are left completely unmarked or return as outright incorrect data. In short, there are instances where the output value simply does not exist, and only the item in context appears.


With EMI image


Without EMI (Note the output counts) image


TLDR; EMI makes assumptions about certain items and the enchantments that they can hold, and EMI fails to provide correct output values for custom recipes.

This has been reported with Immersive Engineering already: https://github.com/BluSunrize/ImmersiveEngineering/issues/5968

AriaElidove commented 5 days ago

The second half is a duplicate of #597 for 1.20.4