emilyploszaj / emi

A featureful and accessible item and recipe viewer
MIT License
254 stars 53 forks source link

Some items are duplicated (Vanilla and Modded ones) #621

Open XBlayz opened 4 months ago

XBlayz commented 4 months ago

Some items (Vanilla and also Modded ones) are duplicated in different position. 2024-07-07_13 07 38 2024-07-07_13 09 11

Also, sometimes, the number of pages is different from launch to launch. 2024-07-07_13 07 05 2024-07-07_13 07 14

Another start

2024-07-07_13 12 13

Minecraft version : 1.20.1 (Forge 47.3.3); EMI version : 1.1.10 Most likely mods that could create incompatibilities :

List of all mods: [✔️] (Forge)SculkHorn-1.20.x-1.4.5.jar [✔️] AdaptiveTooltips-1.3.0-fabric-1.20.2.jar [✔️] AdvancementPlaques-1.20.1-forge-1.5.1.jar [✔️] almostunified-forge-1.20.1-0.9.3.jar [✔️] amecs-1.3.10+mc.1.20.1.jar [✔️] AnimaticaReforged-1.20.1-0.1.3.jar [✔️] antique-atlas-2.9.5+1.20.jar [✔️] appleskin-forge-mc1.20.1-2.5.1.jar [✔️] architectury-9.2.14-forge.jar [✔️] armorchroma-1.2.6.jar [✔️] awesomedungeonocean-forge-1.20.1-3.3.0.jar [✔️] BadOptimizations-2.1.4-1.20.1.jar [✔️] badpackets-forge-0.4.3.jar [✔️] BetterAdvancements-NeoForge-1.20.1-0.4.2.10.jar [✔️] betterbiomeblend-1.4.2.jar [✔️] BetterF3-7.0.2-Forge-1.20.1.jar [✔️] BetterTridents-v8.0.1-1.20.1-Forge.jar [✔️] bettervillage-forge-1.20.1-3.2.0.jar [✔️] BoccHUD-0.1.7-mc1.20.1.jar [✔️] BodiesBodies-1.0.1.jar [✔️] caelus-forge-3.2.0+1.20.1.jar [✔️] canary-mc1.20.1-0.3.3.jar [✔️] catalogue-forge-1.20.1-1.8.0.jar [✔️] cavedust-2.0.4-1.20.1-forge.jar [✔️] CGM-Unofficial-1.4.17+Forge+1.20.1.jar [✔️] CHA-S-1.20-forge.jar [✔️] Chunky-1.3.146.jar [✔️] cloth-config-11.1.118-forge.jar [✔️] ColdSweat-2.2.5.1.jar [✔️] collective-1.20.1-7.70.jar [✔️] CombatNouveau-v8.0.5-1.20.1-Forge.jar [✔️] configured-forge-1.20.1-2.2.3.jar [✔️] Connector-1.0.0-beta.44+1.20.1.jar [✔️] ConnectorExtras-1.11.2+1.20.1.jar [✔️] Controlling-forge-1.20.1-12.0.2.jar [✔️] copycats-1.3.8+mc.1.20.1-forge.jar [✔️] corn_delight-1.0.4-1.20.1.jar [✔️] CrabbersDelight-1.20.1-1.1.5a.jar [✔️] cratedelight-2024.06.21-1.20.1-forge.jar [✔️] create_aquatic_ambitions-1.20.1-1.1.1.jar [✔️] create_armor_trims-1.20.1-2.0.1.jar [✔️] create_connected-0.8.2-mc1.20.1-all.jar [✔️] create_enchantment_industry-1.20.1-for-create-0.5.1.f-1.2.9.d.jar [✔️] create_high_pressure-1.1.0.jar [✔️] create_misc_andthings 1.20.1_4.0A.jar [✔️] create_power_loader-1.5.0-mc1.20.1.jar [✔️] create-1.20.1-0.5.1.f.jar [✔️] createaddition-1.20.1-1.2.4d.jar [✔️] createaddoncompatibility-v0.2.1-1.20.1-(neo)forge.jar [✔️] createbigcannons-forge-1.20.1-0.5.4.jar [✔️] createdieselgenerators-1.20.1-1.2i.jar [✔️] createmetallurgy-0.0.3-1.20.1.jar [✔️] create-stuff-additions1.20.1_v2.0.4a.jar [✔️] Crystal-Clear-2.1-Beta-forge.jar [✔️] CullLessLeaves-Reforged-1.20.1-1.0.5.jar [✔️] curioattribute-1.4.5.jar [✔️] curios-forge-5.9.1+1.20.1.jar [✔️] curious_armor_stands-1.20-5.1.0.jar [✔️] CustomSkinLoader_ForgeV2-14.20.jar [✔️] CutThrough-v8.0.2-1.20.1-Forge.jar [✔️] Delightful-1.20.1-3.5.6.jar [✔️] delightfulburgers-1.20.1.jar [✔️] delightfulsandwich-1.20.1.jar [✔️] DerexMaceMod-1.20.1-8.1.7.2.jar [✔️] dimthread-1.20.1-v1.0.5.jar [✔️] dismountentity-1.20.1-3.3.jar [✔️] DistantHorizons-2.1.2-a-1.20.1-forge-fabric.jar [✔️] dropz-forge-2.2.0+1.20.1.jar [✔️] dynamic-fps-3.6.0+minecraft-1.20.0-forge.jar [✔️] EasyMagic-v8.0.1-1.20.1-Forge.jar [✔️] eating-animation-1.20+1.9.61.jar [✔️] EchoChest-v8.0.0-1.20.1-Forge.jar [✔️] elytra_physics-forge-2.0.jar [✔️] elytraslot-forge-6.4.0+1.20.1.jar [✔️] elytratrims-forge-3.3.0+1.20.1.jar [✔️] embeddium-0.3.24+mc1.20.1.jar [✔️] embeddiumplus-1.20.1-v1.2.13.jar [✔️] EMI Create Schematics [1.0.0 Forge 1.20.1].jar [✔️] emi_loot-0.6.6+fix3+1.20.1+forge.jar [✔️] emi-1.1.10+1.20.1+forge.jar [✔️] emiffect-forge-1.1.2+mc1.20.1.jar [✔️] emitrades-forge-1.2.1+mc1.20.1.jar [✔️] ends_delight-1.20.1-2.3.jar [✔️] entity_model_features_forge_1.20.1-2.1.3.jar [✔️] entity_texture_features_forge_1.20.1-6.1.3.jar [✔️] entityculling-forge-1.6.6-mc1.20.1.jar [✔️] eugenes_horse_whistle-1.1.2.jar [✔️] exposure-1.20.1-1.7.2-forge.jar [✔️] fabric-api-0.92.2+1.11.8+1.20.1.jar [✔️] FarmersDelight-1.20.1-1.2.4.jar [✔️] Fastload-Reforged-mc1.20.1-3.4.0.jar [✔️] ferritecore-6.0.1-forge.jar [✔️] fishnostuck-mc1.20.1-v1.0.3-forge.jar [✔️] fishontheline-1.20.1-3.2.jar [✔️] framework-forge-1.20.1-0.7.6.jar [✔️] freecam-forge-modrinth-1.2.1+1.20.jar [✔️] geckolib-forge-1.20.1-4.4.7.jar [✔️] grind-enchantments-3.1.2+1.20.jar [✔️] highlight-forge-1.20-2.0.1.jar [✔️] HorseBuff-1.20-2.1.2.jar [✔️] horseshoes-1.0.3.jar [✔️] horsestatsmod-MC1.20.x-1.4.7.jar [✔️] Iceberg-1.20.1-forge-1.1.21.jar [✔️] ImmediatelyFast-Forge-1.2.18+1.20.4.jar [✔️] Incendium_1.20.x_v5.3.5.jar [✔️] interiors-0.5.3+forge-mc1.20.1.jar [✔️] InventoryProfilesNext-forge-1.20-1.10.10.jar [✔️] Item-Obliterator-NeoForge-MC1.20.1-2.3.1.jar [✔️] itemswapper-fabric-0.6.3-mc1.20.1.jar [✔️] Jade-1.20.1-forge-11.9.4.jar [✔️] JadeAddons-1.20.1-forge-5.2.2.jar [✔️] jearchaeology-1.20.1-1.0.3.jar [✔️] jei-1.20.1-forge-15.3.0.8.jar [✔️] JustEnoughAdvancements-1.20.1-5.0.1.jar [✔️] justenoughbreeding-forge-1.20.x-1.2.1.jar [✔️] justmobheads-1.20.1-8.1.jar [✔️] kotlinforforge-4.11.0-all.jar [✔️] kubejsadditions-forge-4.3.2.jar [✔️] kubejs-create-forge-2001.2.5-build.2.jar [✔️] kubejs-forge-2001.6.5-build.14.jar [✔️] leafmealone-1.0.1.jar [✔️] libIPN-forge-1.20-4.0.2.jar [✔️] libraryferret-forge-1.20.1-4.0.0.jar [✔️] LibX-1.20.1-5.0.14.jar [✔️] lootjs-forge-1.20.1-2.12.0.jar [✔️] MaFgLib-0.1.11-mc1.20.1.jar [✔️] make_bubbles_pop-0.2.0-forge-mc1.19.4+.jar [✔️] MapTooltip-forge-1.20.1-3.0.1.jar [✔️] mastercutter-1.1.jar [✔️] memoryleakfix-forge-1.17+-1.1.5.jar [✔️] MindfulDarkness-v8.0.3-1.20.1-Forge.jar [✔️] miners_delight-1.20.1-1.2.3.jar [✔️] MiniHUD-Extra-0.2.1-mc1.20.1-forge.jar [✔️] modernfix-forge-5.18.1+mc1.20.1.jar [✔️] moredelight-1.1.2-1.20.1-forge.jar [✔️] MyNethersDelight-1.20.1-1.6.3.jar [✔️] mysterious_mountain_lib-1.4.7-1.20.1.jar [✔️] NaturesCompass-1.20.1-1.11.2-forge.jar [✔️] Necronomicon-Forge-1.4.2.jar [✔️] NetherChested-v8.0.3-1.20.1-Forge.jar [✔️] netherite_horse_armor-forge-1.20.1-1.0.4.jar [✔️] notenoughanimations-forge-1.7.4-mc1.20.1.jar [✔️] notenoughcrashes-4.4.7+1.20.1-forge.jar [✔️] Nullscape_1.20.x_v1.2.6.jar [✔️] ObsidianUI-forge-0.2.3+mc1.20.1.jar [✔️] oculus-flywheel-compat-1.20.1-0.2.5.jar [✔️] oculus-mc1.20.1-1.7.0.jar [✔️] Paxi-1.20-Forge-4.0.jar [✔️] purpurpack-axolotls-ignore-passives-1.5.jar [✔️] purpurpack-breed-axolotl-with-tropical-fish-item-1.2.jar [✔️] purpurpacks-axe-effective-skulls-1.5.jar [✔️] purpurpacks-chiseled-bookshelves-add-enchantment-power-1.5.jar [✔️] purpurpacks-hoe-effective-cactus-1.4.jar [✔️] purpurpacks-hoe-effective-froglights-1.4.jar [✔️] purpurpacks-infinity-on-crossbows-1.1.jar [✔️] purpurpacks-more-dyed-wool-and-carpet-2.3.jar [✔️] purpurpacks-one-step-dyed-shulker-boxes-1.3.jar [✔️] purpurpacks-pickaxe-effective-glass-1.4.jar [✔️] purpurpacks-pickaxe-effective-light-source-blocks-1.4.jar [✔️] purpurpacks-rebalanced-piglin-bartering-1.3.jar [✔️] purpurpacks-re-dye-concrete-powder-1.3.jar [✔️] purpurpacks-re-dye-glass-1.3.jar [✔️] purpurpacks-re-dye-terracotta-1.3.jar [✔️] purpurpacks-transparent-blocks-in-enchant-area-1.3.jar [✔️] PuzzlesLib-v8.1.21-1.20.1-Forge.jar [✔️] radiantgear-forge-2.1.5+1.20.1.jar [✔️] rayon-forge-1.7.2+1.20.1.jar [✔️] ResourcePackOverrides-v8.0.3-1.20.1-Forge.jar [✔️] rhino-forge-2001.2.2-build.18.jar [✔️] rrls-4.0.6.1+mc1.20.1-forge.jar [✔️] RyoamicLights-forge-0.2.3+mc1.20.1.jar [✔️] saturn-mc1.20.1-0.1.3.jar [✔️] scholar-1.20.1-1.0.0-forge.jar [✔️] screenshot_viewer-1.3.2-forge-mc1.20.1.jar [✔️] Searchables-forge-1.20.1-1.0.3.jar [✔️] SereneSeasons-1.20.1-9.0.0.46.jar [✔️] shulkerboxtooltip-forge-4.0.4+1.20.1.jar [✔️] smoothboot(reloaded)-mc1.20.1-0.0.4.jar [✔️] spawnanimations-v1.9.4-mc1.17x-1.20x-mod.jar [✔️] spyglass_of_curios-forge-1.20.1-1.7.2.jar [✔️] Steam_Rails-1.6.4+forge-mc1.20.1.jar [✔️] storagedelight-1.1.1-1.20.1-forge.jar [✔️] superbsteeds-1.20-4.jar [✔️] TacticalFishing-1.20.X1-v1.2.jar [✔️] TaxFreeLevels-1.3.13-forge-1.20.2.jar [✔️] tectonic-forge-1.19.3-2.3.5a.jar [✔️] Terralith_1.20_v2.5.1.jar [✔️] ThinAir-v8.1.5-1.20.1-Forge.jar [✔️] ThirstWasTaken-1.20.1-1.3.8.jar [✔️] titlefixer-1.0+1.20.1.jar [✔️] trainperspectivefix-1.0.0-universal.jar [✔️] trimeffects-forge-1.20.X-1.3.1.jar [✔️] tru.e-ending-v1.1.0c.jar [✔️] Tweakerge-0.1.4-mc1.20.1.jar [✔️] vanilla-refresh-1.4.19h.jar [✔️] villager-transportation-1.3.1.jar [✔️] vintageimprovements-1.20.1-0.1.5.1.jar [✔️] visuality-0.7.1+1.20.jar [✔️] vt-downloader-2.0.8+1.20.1.jar [✔️] YetAnotherConfigLib-3.5.0+1.20.1-fabric.jar [✔️] YungsApi-1.20-Forge-4.0.5.jar

IdrisQe commented 2 months ago

Also experiencing this to an extent. Seems to be specifically "equipment" in my case though:

Vanilla Tools and Weapons (Pickaxes, axes, swords, shield, etc.) are duplicated Vanilla Armour (Chestplates, Boots, etc.) are duplicated Knives from Farmer's Delight are duplicated Armour and Tools from Iron's Spells and Spellbooks are duplicated. Curios from Iron's Spells and Spellbooks and Passive Skill Tree are duplicated The Wrench from Create is duplicated - uniquely it has no "stats" like any other duplicated item. Tool-Weapons (Infernal Forge, Void Forge), and Shields from L. Ender's Cataclysm are duplicated

Other vanilla tools like shears and flint and steel are not Other vanilla equippables like Pumpkins or Mob Heads are not Curios from L. Ender's Cataclysm are not Some weapons (Tidal Claws, Gauntlet of Bulwark) from L. Ender's Cataclysm are not The Pale Gold Amulet Curio from Create Crafts and Additions is not The Goggles from Create, despite being both armour and curio, are not The Skillet from Farmer's Delight which is usable as a weapon is not The Cuisine Skillet from Cuisine Delight, which is also usable as a weapon, is not

Despite having Kubejs we don't have any scripts yet, and we aren't using any datapacks. Mods are:

    - additional_attributes 1.2.1
    - ambientenvironment 11.0.0.1
    - animal_feeding_trough 1.1.0+1.20.1-forge
    - apotheosis 7.4.3
    - apotheosis_ascended 1.20.1-1.6.0
    - apothiccurios 1.0.3d
    - appleskin 2.5.1+mc1.20.1
    - architectury 9.2.14
    - astikorcarts 1.1.8
    - attributefix 21.0.4
    - attributeslib 1.3.7
    - betteradvancements 0.4.2.10
    - bettercombat 1.8.6+1.20.1
    - betterpingdisplay 1.1
    - betterthirdperson 1.9.0
    - bookshelf 20.2.13
    - bountiful 6.0.3+1.20.1
    - caelus 3.1.0+1.20
    - cataclysm 1.99.5
    - cloth_config 11.1.136
    - clumps 12.0.0.4
    - collective 7.84
    - create 0.5.1.h
        \-- flywheel 0.6.11-13
    - createaddition 1.20.1-1.2.4e
    - cuisinedelight 1.1.14
        |-- l2library 2.4.14
        \-- mixinextras 0.2.0-beta.8
    - curios 5.10.0+1.20.1
    - distinguishedpotions 8.0.2
    - doubledoors 5.9
    - e4mc_minecraft 5.2.1
    - effectdescriptions 8.0.2
    - embeddium 0.3.31+mc1.20.1
        \-- rubidium 0.7.1
    - emi 1.1.13+1.20.1+forge
    - emiffect 1.1.2+mc1.20.1
    - enchdesc 17.1.18
    - entity_model_features 2.2.6
    - entity_texture_features 6.2.5
    - entityculling 1.7.0
    - fantasyfurniture 9.0.0
        |-- apexcore 10.0.0
        \-- commonality 7.0.0
    - farmersdelight 1.20.1-1.2.4
    - ferritecore 6.0.1
    - forge 47.3.0
    - geckolib 4.4.9
    - healthindicatortxf 1.20.1-1.2.8-forge
        \-- configlibtxf 4.2.4-forge
    - immediatelyfast 1.2.21+1.20.4
    - inventorysorter 23.1.3
    - irons_spellbooks 1.20.1-3.4.0
    - itemproductionlib 1.0.2a
    - jade 11.10.1+forge
    - jei 15.19.5.99
    - kambrik 6.1.1+1.20.1
    - kotlinforforge 4.11.0
    - kubejs 2001.6.5-build.14
    - lionfishapi 1.9
    - maxhealthfix 12.0.3
    - memoryleakfix 1.1.5
    - minecraft 1.20.1
    - modelfix 1.15
    - mousetweaks 2.25.1
    - nochatreports 1.20.1-v2.2.2
    - notenoughanimations 1.7.6
    - overflowingbars 8.0.0
    - patchouli 1.20.1-84-FORGE
    - pickupnotifier 8.0.0
    - placebo 8.6.2
    - playeranimator 1.0.2-rc1+1.20
    - polymorph 0.49.5+1.20.1
        \-- spectrelib 0.13.15+1.20.1
    - puzzleslib 8.1.23
        \-- puzzlesaccessapi 8.0.7
    - radium 0.12.4+git.26c9d8e
    - rhino 2001.2.3-build.6
    - rrls 4.0.6.1+mc1.20.1-forge
    - skilltree 0.6.14a
    - sliceanddice 3.3.0
    - sound_physics_remastered 1.20.1-1.4.5
    - stylisheffects 8.0.2
    - tipsylib 2.0.9
    - xaerominimap 24.4.0
    - xaeroworldmap 1.39.0
    - yet_another_config_lib_v3 3.5.0+1.20.1-forge
lihaan commented 4 days ago

For me, this is when using the Mouse Wheelie mod on Fabric 1.20.1, which causes fishing rods from the Tide to be duplicated. I know Mouse Wheelie mod provides inventory sorting functionality based on the order of the creative inventory, but I am unsure how this can cause duplication of the items if it is a read-only operation.

I am using EMI v1.1.18, Mouse Wheelie v1.13.0, Tide v1.3.4. Below are some additional observations I made which I hope is helpful when debugging.

When pulling from default Creative index (searching "fishing rod"), the duplicates can be seen: image

If it helps, I noticed that while the item stacks ID are the same (eg. tide:stone_fishing_rod), the NBT data is arranged differently between two instances of the same item. Note that the second : image image

The issue goes away when pulling from Registered index (searching "fishing rod"), but this is not ideal as many mod authors leave their dev work visible. The NBT data of the fishing rods in the screenshot below follows the 2nd image (ie. the one where the bobber data comes first) image