emilyploszaj / trinkets

A data-driven accessory mod and API for Minecraft using Fabric.
https://www.curseforge.com/minecraft/mc-mods/trinkets
MIT License
171 stars 73 forks source link

Please update to support 1.19.4 Fabric #236

Closed lospejos closed 1 year ago

lospejos commented 1 year ago

When trying on Fabric 1.19.4:

trinkets-3.5.1 fabric-api-0.76.0+1.19.4

Crash occur on startup:

[20:26:29] [Render thread/ERROR]: Minecraft has crashed! net.fabricmc.loader.impl.FormattedException: java.lang.RuntimeException: Mixin transformation of net.minecraft.class_490 failed
...
Caused by: java.lang.RuntimeException: Mixin transformation of net.minecraft.class_490 failed
...
Caused by: org.spongepowered.asm.mixin.transformer.throwables.MixinTransformerError: An unexpected critical error was encountered
...
Caused by: org.spongepowered.asm.mixin.injection.throwables.InjectionError: Critical injection failure: Callback method drawBackground(Lnet/minecraft/class_4587;FIILorg/spongepowered/asm/mixin/injection/callback/CallbackInfo;)V in trinkets.mixins.json:InventoryScreenMixin from mod trinkets failed injection check, (0/1) succeeded. Scanned 1 target(s). Using refmap trinkets-refmap.json
...

There is a record in trinkets-refmap.json:

"drawSlot": "Lnet/minecraft/class_465;method_2385(Lnet/minecraft/class_4587;Lnet/minecraft/class_1735;)V",

which is probably causes this crash.