search

emilyploszaj / trinkets

A data-driven accessory mod and API for Minecraft using Fabric.
https://www.curseforge.com/minecraft/mc-mods/trinkets
MIT License
171 stars 73 forks source link

1.20 #252

Closed IMS212 closed 1 year ago

IMS212 commented 1 year ago

Seems to work perfectly, including testmod.

emilyploszaj commented 1 year ago

Hey- don't want to leave this unresponded to for too long. I appreciate this update and assuming it looks good plan to merge it, but currently don't have the time to review it, I'll try to get to it in the next couple of days, thanks for your contribution :slightly_smiling_face:

CammiePone commented 1 year ago

Fingers crossed it's all good! I just tried porting Icarus to 1.20 but some mixins in Trinkets failed because Mojang made some changes.

parzivail commented 1 year ago

Looking forward to it! The last roadblock before the PSWG 1.20 release.

AlphaMode commented 1 year ago

This is truly a new age in modding

Noaaan commented 1 year ago

While someone might see these PR reviews and instantly label it as mindless trolling... This is not what I had in mind when reviewing this.

Today we were directly attacked in the form of malware, yet together with the fast acting of many community members, including Emily, we were able to do an incredible amount of work to prevent many users from being harmed and affected by it.

We are coming together as a community, to show an act of solidarity against these perpetrators. Them trying to harm us at the worst possible time, just before a major update day.

Emily mentioned that she would not be able to port Trinkets, an important mod for many of us, due to her work in keeping everyone safe. Because of this, I have taken it upon myself, with some help from glisco, Blod, chyz, alphamode and a few other reviewers to help out in getting it ported in time.

Consider this a love letter to the entire community. Thank you all for your wonderful work. Lets make 1.20 and the next years going forward be the best they can be!

(We are actually making some bug fixes by the way, this is not completely baseless)

IMS212 commented 1 year ago

counterpoint: I have push notifications on

tiny potato

emilyploszaj commented 1 year ago

I intended to have this published but I am busy organizing and attempting to mitigate the fractureiser incident. I can't stop you from meming but just letting those know who care that I will be taking a look at this when my time isn't spent elsewhere.

leasomeone commented 1 year ago

dayum the whole team ported to 1.20 <3

AlphaMode commented 1 year ago

Rejoice! This legendary PR has finally been merged