emilyploszaj / trinkets

A data-driven accessory mod and API for Minecraft using Fabric.
https://www.curseforge.com/minecraft/mc-mods/trinkets
MIT License
172 stars 73 forks source link

Missing green library badge in modmenu #280

Open nco2k opened 1 year ago

nco2k commented 1 year ago

can you please modify your mod so that it gets properly recognized as a library by modmenu, and therefor doesnt show up by default?

apis like fabric, cloth, yacl etc. have a green library badge in modmenu, and only show up if you toggle the button from "Libraries: Hidden" to "Libraries: Shown". i would appreciate it if your library behaved the same.

emilyploszaj commented 1 year ago

While EMI has an API, it's not a library in a traditional sense. It should not be included by mods in their jars, users interact with it significantly, and it has a pretty large config that should be accessible by default in modmenu. For this reason, it's not a "library" in modmenu

nco2k commented 1 year ago

im not talking about EMI, im talking about Trinkets.

emilyploszaj commented 1 year ago

:sweat_smile: my mistake, I need to pay more attention to my emails.