Closed Lakuna closed 8 months ago
There seems to be no code changes, is this necessary for cca?
There seems to be no code changes, is this necessary for cca?
No code changes were required to make the test mod run. I can try running it again without updating CCA if you'd like? I figured that it would be preferable to use the version that was created for Minecraft 1.20.4 so that users wouldn't complain about mismatching versions.
The update does appear to work fine without updating CCA. Trinkets actually works fine for 1.20.4 as-is, but I figured that it would be a good idea to update dependencies in case there are edge cases that the test mod and mine doesn't cover.
If you'd rather not update anything I can just close this PR.
The PR seems reasonable so I'll merge if you remove the version bump, and just not make a release until something prompts it. Thanks for your contribution.
Done.
Don't know if this is the proper place, but this release got marked as 1.20.2-only in Modrinth.
Don't know if this is the proper place, but this release got marked as 1.20.2-only in Modrinth.
The 1.20.2 release still works for 1.20.4. Although this PR has been merged, it hasn't actually been included in any releases yet.
This pull request updates Trinkets to work with Minecraft version 1.20.4.
CC: @emilyploszaj
Changelog
sourceCompatibility
andtargetCompatibility
tojava.sourceCompatibility
andjava.targetCompatibility
, respectively (previous functionality was deprecated; see here).archivesBaseName
tobase.archivesName
(previous functionality was deprecated; see here).fabric
tofabric-api
(recommended since Minecraft version 1.19.2; see here).