search

emilyploszaj / trinkets

A data-driven accessory mod and API for Minecraft using Fabric.
https://www.curseforge.com/minecraft/mc-mods/trinkets
MIT License
165 stars 72 forks source link

Add Support for Entity Model Features: Player Animations #313

Open HB-Stratos opened 2 months ago

HB-Stratos commented 2 months ago

Entity Model Features adds compatibility for Optifine's Custom Entity Models, and extends the system so resource packs can animate the player too. This requires a custom renderer for the player model, which currently doesn't work with the TrinketRenderer.translateTo... functions. The result is that cosmetics rendered by custom renderers, like the create mod goggles (renderer code here), do not move correctly with the player as they assume vanilla player model movement.

https://github.com/emilyploszaj/trinkets/assets/56313836/524c93ef-716c-4749-95bf-7b09004a748b

Having searched around a bit I believe the best way to fix this may be to extend the TrinketRenderer.translateTo... functions to detect whether EMF is currently present and the custom player model feature is in use, and if so, it should provide rotation matrices that follow the player model rendered by EMF.

N0aW commented 2 months ago

Same problem. I think all mods that make the player have extra animations cause this issue, because it happened with Immersive Melodies and Better Combat

Unless those two use EMF too?

secretchowc commented 3 weeks ago

have you found a solution? image image https://www.curseforge.com/minecraft/mc-mods/animationoverhaul https://www.curseforge.com/minecraft/mc-mods/skin-layers-3d

HB-Stratos commented 3 weeks ago

as far as I know there currently is no solution. The feature needs to be implemented by either trinkets or EMF to get this fixed.

secretchowc commented 3 weeks ago

damn, and do you know if they listen to the community? because this was published in May and it is almost July.