search

emilyst / hid-nx-dkms

Alternative Linux kernel HID driver for Nintendo Switch controllers
GNU General Public License v2.0
40 stars 6 forks source link

Pro Controller disconnects when using rumble #9

Open nfp0 opened 1 year ago

nfp0 commented 1 year ago

@emilyst I'm creating this issue to try and bring your attention to this longstanding issue upstream that is also affecting your fork: https://github.com/DanielOgorchock/linux/issues/33

We've been trying to figure out what is causing this disconnection, but without success, and the maintainer has not been responding much. Since you might have more insight on the inner workings of this module, I have hopes you might help us somehow.

Long story short, the Pro Controller consistently disconnects when rumble is in use (rumble intensity does not seem to matter). This was tested by me on 5 different Bluetooth radios. Some internal, some USB. The issue is consistent with all of them. (details here: https://github.com/DanielOgorchock/linux/issues/33#issuecomment-1125000229).

I can reproduce the issue easily, so I can provide you with any debugging info you might need if you can't reproduce it.

emilyst commented 1 year ago

@emilyst I'm creating this issue to try and bring your attention to this longstanding issue upstream that is also affecting your fork: DanielOgorchock/linux#33

Fascinating. I hadn't seen this. Thanks for sharing it.

We've been trying to figure out what is causing this disconnection, but without success, and the maintainer has not been responding much. Since you might have more insight on the inner workings of this module, I have hopes you might help us somehow.

FWIW, I have been totally unable to reach @DanielOgorchock via email, GitHub, etc. That's the entire reason I made this fork.

Long story short, the Pro Controller consistently disconnects when rumble is in use (rumble intensity does not seem to matter). This was tested by me on 5 different Bluetooth radios. Some internal, some USB. The issue is consistent with all of them. (details here: DanielOgorchock/linux#33 (comment)).

I can reproduce the issue easily, so I can provide you with any debugging info you might need if you can't reproduce it.

I'll have to read through all those comments first, but you should know I haven't touched the rumble code much. Perhaps I could expose some module parameters for whether or not to enable rumble, how deep the queue should be, etc.

I appreciate your help confirming this issue got ported over to my driver.

nfp0 commented 1 year ago

No problem! Please tell me if you can replicate the issue on your end. If you can't, I'm here to help any way I can. I can usually reproduce the issue in less than 60 seconds, but I don't know how to properly debug this.

I have been totally unable to reach @DanielOgorchock via email, GitHub, etc.

I believe he mentioned somewhere that he's not active on GitHub anymore and we should report bugs upstream on bugzilla. An issue was open for this here: https://bugzilla.kernel.org/show_bug.cgi?id=216218

DanielOgorchock commented 1 year ago

@emilyst I'm creating this issue to try and bring your attention to this longstanding issue upstream that is also affecting your fork: DanielOgorchock/linux#33

Fascinating. I hadn't seen this. Thanks for sharing it.

We've been trying to figure out what is causing this disconnection, but without success, and the maintainer has not been responding much. Since you might have more insight on the inner workings of this module, I have hopes you might help us somehow.

FWIW, I have been totally unable to reach @DanielOgorchock via email, GitHub, etc. That's the entire reason I made this fork.

Long story short, the Pro Controller consistently disconnects when rumble is in use (rumble intensity does not seem to matter). This was tested by me on 5 different Bluetooth radios. Some internal, some USB. The issue is consistent with all of them. (details here: DanielOgorchock/linux#33 (comment)). I can reproduce the issue easily, so I can provide you with any debugging info you might need if you can't reproduce it.

I'll have to read through all those comments first, but you should know I haven't touched the rumble code much. Perhaps I could expose some module parameters for whether or not to enable rumble, how deep the queue should be, etc.

I appreciate your help confirming this issue got ported over to my driver.

Hi @emilyst. Apologies for the difficulty getting in touch with me. I've been kind of bad about keeping up with my GitHub notifications as of late.

I'd love to get your Nintendo Switch online controller support included in the upstream kernel driver. If you are interested, please submit your patch set to the linux-input mailing list, and I will review it (as well as others on the mailing list).

As for this rumble disconnect problem: it's been plaguing me for a long time. I'll give a more detailed reply in the issue in my repo.