Remove lazy-static dependency

eminence / procfs

Rust library for reading the Linux procfs filesystem

Other

358 stars 105 forks source link

Remove lazy-static dependency #308

Closed notgull closed 2 months ago

notgull commented 2 months ago

lazy-static is on its way to being deprecated. I'm trying to remove it from my dependency tree. Therefore I've removed lazy-static from this crate in this commit.

Modifications made:

PAGESIZE and TICKS_PER_SECOND appear to be unused so I've removed them.
KERNEL can be replaced with racy atomic initialization.
RANDOM_ROOT doesn't really need to be allocated on the heap, so I've replaced it with manual Path::new.

eminence commented 2 months ago

Thanks, on quick skim this looks good, will review more carefully later

notgull commented 2 months ago

@eminence Have you had a chance to review this more carefully?

eminence commented 2 months ago

LGTM, thanks!

eminence commented 2 months ago

I'm trying to remove it from my dependency tree.

I'm always curious to know where/how procfs is used, so if you're comfortable sharing, where is procfs being used in your deptree?

notgull commented 2 months ago

I'm always curious to know where/how procfs is used, so if you're comfortable sharing, where is procfs being used in your deptree?

I was taking bpftop for a spin when I realized that procfs was pulling in lazy-static in its dependency tree.