search

eminence / xmltree-rs

Reads an XML file into a simple tree structure
MIT License
39 stars 30 forks source link

[FEAT] Slight restructuring to allow for comments, better text handli… #18

Closed dyst5422 closed 4 years ago

dyst5422 commented 4 years ago

…ng, and allowing more information to be passed through

Haven't gotten to the tests yet.

dyst5422 commented 4 years ago

I like that solution. Yeah, I wasn’t so hot on the different parse signature myself, but wanted to ensure completeness in what is returned. I think parse_all satisfies both.

dyst5422 commented 4 years ago

Just added parse_all and reverted the signature for parse. Additionally, all tests pass and a test was added checking that parse_all returns the proper number of nodes.

eminence commented 4 years ago

Thanks! I've merged this, plus added a few new features. This has been published as v0.10.0