eminfedar / vaktisalah-gtk-rs

Rust & GTK4 version of Vakt-i Salah (Prayer Times) Application
MIT License
21 stars 1 forks source link

Inaccurate Salah times in Egypt #5

Open muhammadalkady opened 3 months ago

muhammadalkady commented 3 months ago

Screenshot from 2024-04-09 12-29-07 You can see the difference between the app and Google search for prayer times, which is correct. Thanks

eminfedar commented 3 months ago

On Google search, you can see the comment at bottom left: Based on Egyptian General Authority of Survey

This app pulls prayer times from Türkiye's Religious Affairs website. So the prayer times other than Türkiye will slightly be different because of different calculation methods used.

One solution for this is adding different calculation methods and calculating times with GPS coordinates rather than fetching already calculated value from web.

I couldn't find a single all in one solution because there are always couple minutes differences between local and global calculations. I tried the islam crate. There is no Turkish calculation method and it doesn't fit with Türkiye's own calculations. Maybe other methods are working well but I don't know because I don't know their local calculations :).

If every other place is true other than Türkiye in islam crate, then maybe I can use it after adding Türkiye as a method too. 🤔

This program, for now, works best in Türkiye, because of the prayer times fetched from Türkiye's Religious Affairs API.

muhammadalkady commented 3 months ago

I think adding other calculation methods along the ability to add an offset -/+ per salah will be a good option for now.

Edit: Please also check this https://github.com/azzamsa/bilal