search

eminiarts / nova-tabs

Laravel Nova Tabs Package
464 stars 139 forks source link

Display none on h1 in trix fields #294

Open diogo-vf opened 1 year ago

diogo-vf commented 1 year ago

Description:

Within a tab, we notice a problem when trying to apply a heading tag to some text using a Trix field: image

The text disappears, because there is a wrong style that sets display: none on the <h1> tag. image

Detailed steps to reproduce the issue on a fresh Nova installation:

Write any text, it'll display as normal image

After clicking on the Heading button, the text disappears from the interface. You can see in the dev tools that the heading is display: none image

bram-pkg commented 11 months ago

Bump, this is also causing issues for us.

FYI @diogo-vf we fixed it by adding:

.trix-content h1 {
    /* important is needed here because of the nova tabs making h1 display none */
    display: block !important;
}

To our theme.css, which you can register using Nova::style('my-app-name', resource_path('path/to/stylesheet.css'));

diogo-vf commented 11 months ago

Bump, this is also causing issues for us.

FYI @diogo-vf we fixed it by adding:

.trix-content h1 {
    /* important is needed here because of the nova tabs making h1 display none */
    display: block !important;
}

To our theme.css, which you can register using Nova::style('my-app-name', resource_path('path/to/stylesheet.css'));

Thank you !

phlisg commented 11 months ago

Cheers for the temp fix @bram-pkg