emissary-ingress / emissary

open source Kubernetes-native API gateway for microservices built on the Envoy Proxy
https://www.getambassador.io
Apache License 2.0
4.36k stars 683 forks source link

Ambassador should support Knative TLS #1725

Open iNoahNothing opened 5 years ago

iNoahNothing commented 5 years ago

Knative allows for you to specify TLS contexts in a ClusterIngress. (see below)

Ambassador should support creating a TLSContext based off this config:

  spec:
    rules:
    - hosts:
      - hello-app.default.ambassador.gymk8s03.ncloud.fslab.ntap
      - hello-app.default.svc.cluster.local
      http:
        paths:
        - appendHeaders:
            Knative-Serving-Namespace: default
            Knative-Serving-Revision: hello-app-q5vn4
          retries:
            attempts: 3
            perTryTimeout: 10m0s
          splits:
          - percent: 100
            serviceName: hello-app-q5vn4
            serviceNamespace: default
            servicePort: 80
          timeout: 10m0s
    tls:
    - hosts:
      - hello-app.default.ambassador.gymk8s03.ncloud.fslab.ntap
      privateKey: tls.key
      secretName: route-ddc724e0-b325-11e9-a69d-005056bd013b
      secretNamespace: default
      serverCertificate: tls.crt
    visibility: ExternalIP
stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

concaf commented 4 years ago

pas stale

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

kflynn commented 4 years ago

Leave this issue alone, bot.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

concaf commented 4 years ago

no

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

concaf commented 4 years ago

no

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

iakat commented 3 years ago

not stale