emissary-ingress / emissary

open source Kubernetes-native API gateway for microservices built on the Envoy Proxy
https://www.getambassador.io
Apache License 2.0
4.37k stars 687 forks source link

Register Ambassador as a Consul service #3261

Open FriedCircuits opened 3 years ago

FriedCircuits commented 3 years ago

Please describe your use case / problem.

Consul has rolled out a topology graph to show connections between services and realtime metrics in the Consul UI when using Connect. Ambassador supports Consul via ConsulResolver and the Consul Connector deployment but neither Ambassador or the Connector registers itself as a Consul service. This has a few ramifications that would be nice to resolve. I spent hours trying to get it to show up. The documentation makes it seem like it should but other guides call out that it won't show up as Ambassador doesn't register itself. So there are 3 things this would allow.

Describe the solution you'd like If Ambassador could register itself directly in Consul service discovery then it would show as any other service to allow the above functionally. It would also let you know that it is actually working using Consul instead of assuming it is. It also it doesn't show in consul catalog services which makes it hard to troubleshoot and confirm its using Consul connect.

Describe alternatives you've considered There really isn't any alternatives other just good internal documentation to not expect it show up as a registered service.

etotten commented 3 years ago

+1 - I'd love to see Ambassador in the topology graphs