search

emissary-ingress / emissary

open source Kubernetes-native API gateway for microservices built on the Envoy Proxy
https://www.getambassador.io
Apache License 2.0
4.39k stars 688 forks source link

Support envoy `track_remaining` #4328

Open mohitreddy1996 opened 2 years ago

mohitreddy1996 commented 2 years ago

Please describe your use case / problem. Envoy metrics currently trackable are - https://www.envoyproxy.io/docs/envoy/latest/configuration/upstream/cluster_manager/cluster_stats#circuit-breakers-statistics

except for remaining_*

which can be enabled through setting track_remaining

This currently does not seem to be configurable through Ambassador

Describe the solution you'd like Similar to other circuit breaking configurations, allow configuring this as well

Describe alternatives you've considered There does not seem to be alternatives to this?

cindymullins-dw commented 2 years ago

Thanks for this suggestion. Would you be interested in contributing and possibly submitting a PR for this?

mohitreddy1996 commented 2 years ago

Surely :)

Could you point me to a few code pointers which might help me get started?

cindymullins-dw commented 2 years ago

I'll try to find out beforehand, but we will have an Emissary Contributors meeting on 8/3 (I believe) at 1pm ET. Any chance you'd be available for that? Are you in our Slack (a8r.io/slack)?

DanOfir commented 2 years ago

what's the ETA for that?

cindymullins-dw commented 1 year ago

@mohitreddy1996 , @DanOfir if either of you are interested in contributing to this fix please join our next Emissary Contributors meeting, details noted here.

owayss commented 1 year ago

@LanceEa I'd like to tackle this one

LanceEa commented 1 year ago

@owayss - It was great meeting you at ContribFest yesterday. Let me know if you are still interested in contributing and we can help get the dev tooling sorted out by connecting with us in our Slack #emissary-dev channel