emissary-ingress / emissary

open source Kubernetes-native API gateway for microservices built on the Envoy Proxy
https://www.getambassador.io
Apache License 2.0
4.32k stars 683 forks source link

release: reduce KAT test flakiness #4585

Open LanceEa opened 1 year ago

LanceEa commented 1 year ago

Summary

The KAT test can fail in CI because they timeout or never pass readiness checks, etc... This make engineers assume that CI is flaking and adds a ton of time to the release process when it fails for this reason. This also waste time because we will think it is a flake so retry the Github action and wait 20+ minutes to realize that it is an actual error.

Goal

Note: there was some recent PR's that landed on master that have made this better. So this might not be too far off but let's address any other issues that we see and I think we should back port these as well.

LanceEa commented 1 year ago

I observed this today:

Screen Shot 2022-09-29 at 1 29 34 PM

Screen Shot 2022-09-29 at 1 30 17 PM

So, I think some of the recent changes have improved it but we will want to look into this because I just restarted and it turned green.