Open alexionescu opened 1 year ago
To check if I understand, are you saying that - of the severity levels noted below - only ERROR will be output currently? And that's because the wrong key is being used? Have you tested this - could you demonstrate some sample output that shows this?
DEFAULT | (0) The log entry has no assigned severity level. DEBUG | (100) Debug or trace information. INFO | (200) Routine information, such as ongoing status or performance. NOTICE | (300) Normal but significant events, such as start up, shut down, or a configuration change. WARNING | (400) Warning events might cause problems. ERROR | (500) Error events are likely to cause problems. CRITICAL | (600) Critical events cause more severe problems or outages. ALERT | (700) A person must take an action immediately. EMERGENCY | (800) One or more systems are unusable.
@alexionescu - Thanks for creating the issue and for the PR.
A few things from my perspective:
Describe the bug The ambassador diag service will output everything as error severity to GCP logs due to outputting to stderr and the structured JSON field having
levelname
as the key used for logging severity. Per https://cloud.google.com/logging/docs/structured-logging#special-payload-fields the suggest field would beseverity
(I believelevel
can also be used). I have a PR here: https://github.com/emissary-ingress/emissary/pull/4941 which renames the field fromlevelname
toseverity
which would annotate logs from this service at the right level.