emissary-ingress / emissary

open source Kubernetes-native API gateway for microservices built on the Envoy Proxy
https://www.getambassador.io
Apache License 2.0
4.35k stars 680 forks source link

apiext: add rbac for updating crd statuses #5468

Closed LanceEa closed 9 months ago

LanceEa commented 9 months ago

Description

On some locked down clusters, the status update for CRD's will fail due to missing RBAC. This updates the fix-crds tool so that it includes customresourcedefinitions/status in the RBAC permissions when updating CRDs. AFAIK, it seems like it will report an error but still update status in our CI tests which is why we didn't catch this.

This supersedes https://github.com/emissary-ingress/emissary/pull/5449 because the file changed in that PR is generated and would get overridden as soon as make generate was called again. The file is generated via the tools/src/fix-crds using the template defined here: tools/src/fix-crds/apiext.yaml so that has been updated so that make generate is clean now.

Related Issues

Fixes https://github.com/emissary-ingress/emissary/issues/5436

Testing

CI Tests are still passing. Manually testing from user as noted here: https://github.com/emissary-ingress/emissary/pull/5449#issue-2002048514

Checklist

joebowbeer commented 3 months ago

@AliceProxy When will this be released?