emissary-ingress / emissary

open source Kubernetes-native API gateway for microservices built on the Envoy Proxy
https://www.getambassador.io
Apache License 2.0
4.33k stars 682 forks source link

TracingService: `propagation_modes` incompatible with `opentelemetry` driver #5505

Open miguelvr opened 7 months ago

miguelvr commented 7 months ago

Describe the bug Emissary ingress pod enters CrashLoopBackoff when propagation_modes is specified with driver: opentelemetry.

Also, the documentation hints that the way to specify propagation modes is spec.propagation_modes, when in reality it is spec.config.propagation_modes.

To Reproduce

  1. Apply the following TracingService:
    apiVersion: getambassador.io/v3alpha1
    kind: TracingService
    metadata:
    name: tracing
    namespace: emissary
    spec:
    driver: opentelemetry
    service: opentelemetry-collector.opentelemetry:4317
    config:
    service_name: emissary
    propagation_modes: [TRACE_CONTEXT]
    sampling:
    overall: 100
  2. Restart emissary-ingress deployment
  3. Observe the CrashLoopBackOff

Expected behavior

Versions (please complete the following information):