To limit the scope of CRD's being pulled into the Manager cache a resitrction was put on the default labels. This works in most cases when users are using the default crds provided.
However, in some cases users have their own conventions on labels so if the label was modified or removed then the CRD Patching would not work.
This removes the cache option and instead relies upon the getAmbassadorioPredicate for filtering out events for non getambassadorio crds that we do not care about as seen in pkg/apiext/internal/controller/crd/predicate.go
Related Issues
N/A
Testing
No additional testing added at this time.
Checklist
[ ] Does my change need to be backported to a previous release?
[ ] I made sure to update CHANGELOG.md.
[x] This is unlikely to impact how Ambassador performs at scale.
[ ] My change is adequately tested.
[ ] I updated DEVELOPING.md with any any special dev tricks I had to use to work on this code efficiently.
[x] The changes in this PR have been reviewed for security concerns and adherence to security best practices.
Description
To limit the scope of CRD's being pulled into the Manager cache a resitrction was put on the default labels. This works in most cases when users are using the default crds provided.
However, in some cases users have their own conventions on labels so if the label was modified or removed then the CRD Patching would not work.
This removes the cache option and instead relies upon the
getAmbassadorioPredicatefor filtering out events for non getambassadorio crds that we do not care about as seen inpkg/apiext/internal/controller/crd/predicate.goRelated Issues
N/A
Testing
No additional testing added at this time.
Checklist
CHANGELOG.md.DEVELOPING.mdwith any any special dev tricks I had to use to work on this code efficiently.