emissary-ingress / emissary

open source Kubernetes-native API gateway for microservices built on the Envoy Proxy
https://www.getambassador.io
Apache License 2.0
4.32k stars 685 forks source link

Documentation update related module deactivation in Helmchart #5577

Open alexvaque opened 4 months ago

alexvaque commented 4 months ago

Description

about module deactivation in Helmchart the documentation saids that we need to disable module with module: {} but must be module: false

Related Issues

List related issues.

Testing

I deployed in my infrastructure module: {}

but this did not work

Checklist

alexvaque commented 3 months ago

Hi @alexgervais or @AliceProxy, I noticed that you are listed as project maintainers.

Could we please merge this README update? It is a basic change in the code comments nothing else

The documentation has been somewhat confusing as it suggests using module: {} for module deactivation using the Helmchart. However, after conducting personal tests, I found that deactivating the module is achieved with module: false.

To prevent further confusion, I have updated the README accordingly.

Thank you.