Open alexvaque opened 4 months ago
Hi @alexgervais or @AliceProxy, I noticed that you are listed as project maintainers.
Could we please merge this README update? It is a basic change in the code comments nothing else
The documentation has been somewhat confusing as it suggests using module: {} for module deactivation using the Helmchart. However, after conducting personal tests, I found that deactivating the module is achieved with module: false.
To prevent further confusion, I have updated the README accordingly.
Thank you.
Description
about module deactivation in Helmchart the documentation saids that we need to disable module with
module: {}
but must bemodule: false
Related Issues
List related issues.
Testing
I deployed in my infrastructure
module: {}
but this did not work
Checklist
[ ] Does my change need to be backported to a previous release?
[ ] I made sure to update
CHANGELOG.md
.Remember, the CHANGELOG needs to mention:
[ ] This is unlikely to impact how Ambassador performs at scale.
Remember, things that might have an impact at scale include:
[x] My change is adequately tested.
Remember when considering testing:
[ ] I updated
DEVELOPING.md
with any any special dev tricks I had to use to work on this code efficiently.[ ] The changes in this PR have been reviewed for security concerns and adherence to security best practices.