This will appear to be a conflict with existing Emissary charts, but the 4.x charts and the older charts don't live in the same Helm repository, so it doesn't matter.
NOTE WELL: this may be something we need to change later, since right now a Helm-chart-only change will require making new binaries. The goal here is that releases get to be sufficiently lightweight that we don't care.
Also, change the default naming so that we don't end with insane things like a Service named "emissary-ingress-emissary-chart-admin".
Also, change the app.kubernetes.io/name annotation not to default to .Chart.Name -- https://helm.sh/docs/chart_best_practices/labels/ differentiates this from the helm.sh/chart annotation, so use Emissary's name for the app.kubernetes.io/name annotation.
Ditch the a8r.io/* annotations that were left over from older Ambassador Cloud stuff.
Also, I cleaned up the chart README some. Holy crap that was out of date.
https://github.com/emissary-ingress/emissary/pull/5691 needs to land before this.
Four significant changes here:
This will appear to be a conflict with existing Emissary charts, but the 4.x charts and the older charts don't live in the same Helm repository, so it doesn't matter.
NOTE WELL: this may be something we need to change later, since right now a Helm-chart-only change will require making new binaries. The goal here is that releases get to be sufficiently lightweight that we don't care.
Also, change the default naming so that we don't end with insane things like a Service named "emissary-ingress-emissary-chart-admin".
Also, change the
app.kubernetes.io/nameannotation not to default to.Chart.Name-- https://helm.sh/docs/chart_best_practices/labels/ differentiates this from thehelm.sh/chartannotation, so use Emissary's name for theapp.kubernetes.io/nameannotation.Ditch the
a8r.io/*annotations that were left over from older Ambassador Cloud stuff.Also, I cleaned up the chart README some. Holy crap that was out of date.