Emissary creating duplicate mapping routes in ir.json and econf.json

[sekar-saravanan]

Describe the bug Emissary creating duplicate mapping routes in ir.json and econf.json while adding weight for canary release

To Reproduce Steps to reproduce the behavior:

1. Create mapping for original and canary release with weight. It will recreate the ir.json and econf.json. (No duplicates found)
2. Do perform update on any other existing mapping. It will recreate the ir.json and econf.json. (Now we can see the duplicate routes for above created mapping)

Expected behavior Emissary should not create duplicate routes in ir.json and econf.json for canary release

Versions (please complete the following information):

• Ambassador: [3.9.1]
• Kubernetes environment [EKS]
• Version [1.28.9]

Additional context Have attached the deployment.yaml, service.yaml, mappings.yaml, host.yaml and ir.json and econf.json with duplicate routes.

Duplicate routes presents under, ir.json: -> groups -> mappings econf.json: -> listeners -> filter_chains -> filters -> route_config -> virtual_hosts -> routes docs.zip

What is the Impact ? No impacts on traffic.

Other Imapcts:

• Getting IR MISMATCH & ENVOY CONFIG MISMATCH error frequently in the logs, whenever updating any of the mapping object. [https://github.com/emissary-ingress/emissary/blob/master/python/ambassador_diag/diagd.py#L545, https://github.com/emissary-ingress/emissary/blob/master/python/ambassador_diag/diagd.py#L551]
• Taking cpu consumption while getting json_diff. Sometime getting 100% cpu spike when running with bunch of mappings and which leads to envoy failure [https://github.com/emissary-ingress/emissary/blob/master/python/ambassador_diag/diagd.py#L547, https://github.com/emissary-ingress/emissary/blob/master/python/ambassador_diag/diagd.py#L553]
• Also, it's getting json diff for ir.json instead of econf.json [https://github.com/emissary-ingress/emissary/blob/master/python/ambassador_diag/diagd.py#L553]

[juanjoku]

Hello, It is indicated here that it fixes the bug of "duplicate mappings" when there are several analog mappings with different weights. But... would the same problem occur when, for example, there are several analog mappings with different prededence?

In other words, is it intended to fix something more generic than weights?

[sekar-saravanan]

@juanjoku Thanks for your response. I have tried with precedence configuration also. When setting different precedences for 2 mappings (with same host and path) with different weights (for canary purpose), then 100% weight applied for both mappings in econf.json/envoy.json. so traffic always sent to mapping with higher precedence.

[sekar-saravanan]

@juanjoku added fix for this bug. can you please review this PR https://github.com/emissary-ingress/emissary/pull/5705 ?

[sekar-saravanan]

@juanjoku added fix for this bug. can you please review this PR https://github.com/emissary-ingress/emissary/pull/5705 ?