emissary-ingress / emissary

open source Kubernetes-native API gateway for microservices built on the Envoy Proxy
https://www.getambassador.io
Apache License 2.0
4.32k stars 683 forks source link

incorrect nindent for initContainers in helm chart #5703

Open SeanKnight opened 1 week ago

SeanKnight commented 1 week ago

Describe the bug

Can not add my own initContainer if .Values.waitForApiext.enabled is true

https://github.com/emissary-ingress/emissary/blob/chart/v8.9.1/charts/emissary-ingress/templates/deployment.yaml#L178

nindent on line 178 should be 6 to match the indent used on wait-for-apiext on line 136

https://github.com/emissary-ingress/emissary/blob/chart/v8.9.1/charts/emissary-ingress/templates/deployment.yaml#L136

To Reproduce

Steps to reproduce the behavior:

  1. Set .Values.waitForApiext.enabled to true (default setting)
  2. In values.yaml define one or more .initContainers
  3. Template or install chart and get invalid yaml

Expected behavior

To be able to define additional initContainers.

Versions (please complete the following information):

Additional context

Incorrect indent also in this file:

https://github.com/emissary-ingress/emissary/blob/chart/v8.9.1/charts/emissary-ingress/templates/deployment-canary.yaml#L157

SeanKnight commented 1 week ago

Related: