Closed sekar-saravanan closed 1 day ago
_cache_key is getting generated incorrectly for mappings in ir.json, when using header with regex. Always _cache_key should be in the format of {kind}-{version}-{name}-{namespace}. But header name is getting updated in the place of mapping name
https://github.com/emissary-ingress/emissary/issues/5714
manual tests
[ ] Does my change need to be backported to a previous release?
[ ] I made sure to update CHANGELOG.md.
CHANGELOG.md
[ ] This is unlikely to impact how Ambassador performs at scale.
[ ] My change is adequately tested.
[ ] I updated DEVELOPING.md with any any special dev tricks I had to use to work on this code efficiently.
DEVELOPING.md
[ ] The changes in this PR have been reviewed for security concerns and adherence to security best practices.
I'm going to close this in favor of #5716 – @sekar-saravanan, thanks! 🙂
Description
_cache_key is getting generated incorrectly for mappings in ir.json, when using header with regex. Always _cache_key should be in the format of {kind}-{version}-{name}-{namespace}. But header name is getting updated in the place of mapping name
Related Issues
https://github.com/emissary-ingress/emissary/issues/5714
Testing
manual tests
Checklist
[ ] Does my change need to be backported to a previous release?
[ ] I made sure to update
CHANGELOG.md
.[ ] This is unlikely to impact how Ambassador performs at scale.
[ ] My change is adequately tested.
[ ] I updated
DEVELOPING.md
with any any special dev tricks I had to use to work on this code efficiently.[ ] The changes in this PR have been reviewed for security concerns and adherence to security best practices.