search

emissions-api / sentinel5dl

Sentinel-5(P) Downloader
https://sentinel5dl.emissions-api.org
MIT License
12 stars 9 forks source link

add argparse, validation, and defaults #35

Closed cfletemier closed 4 years ago

cfletemier commented 4 years ago

Added argparse with defaults matching the same values in the original search() call per #1

I've added some general validation but I'm happy to add more or change it up per any feedback. #

lkiesow commented 4 years ago

Hi @cfletemier, thanks for finishing this! Unfortunately, as you might have already noticed yourself, this pull request is based on an old state of sentinel5dl and has some merge conflicts.

If you don't mind, I'll quickly rebase this, fix the problems and propose a few minor changes. Or do you prefer to do that yourself? In that case, I would point out a few places of this patch I would suggest to slightly change.

cfletemier commented 4 years ago

Given that I don't have write access, I don't mind if you do the rebase. I'll happy address any and all feedback you have for this. Thanks!

lkiesow commented 4 years ago

You do have write access since this would happen on your branch cfletemier:add_argparse but you also gave us write access to that specific branch ;-). I'll propose a change this evening (UTC+1) and add comments about what I did change and why. You can then review the changes and let me know if you like them.