search

emissions-api / sentinel5dl

Sentinel-5(P) Downloader
https://sentinel5dl.emissions-api.org
MIT License
12 stars 9 forks source link

Retry requests #19 #41

Closed EmbeddedHenni closed 4 years ago

EmbeddedHenni commented 4 years ago

adds timeout and auto retry to http_request closing #19

EmbeddedHenni commented 4 years ago

TODO: return failed http_request

EmbeddedHenni commented 4 years ago

@lkiesow: it seems that coveralls failed because the new lines i wrote are not covered. im totaly new to testing and have no clue how to fix that. can you give me a source of information?

shaardie commented 4 years ago

@EmbeddedHenni This branch is based on certifi branch which makes it difficult to review. You could either wait for #37 to be merged or make your changes from the master branch instead of the certifi branch.

lkiesow commented 4 years ago

@EmbeddedHenni, there was the minor matter of a dash invalidating the certifi option which I took the liberty of fixing while merging this:

-    if args.use-certifi:                                                                                                                                                                                                                     
+    if args.use_certifi:

Merged.