Closed dawsontoth closed 5 years ago
It looks like appveyor is failing on something unrelated to my changes.
C:\projects\csharp-133tg\Emitter\Emitter.NetCore.xproj(7,3): error MSB4019: The imported project "C:\Program Files\dotnet\sdk\1.0.4\Microsoft\VisualStudio\v14.0\DotNet\Microsoft.DotNet.Props" was not found. Confirm that the path in the
declaration is correct, and that the file exists on disk. 0 Warning(s) 1 Error(s) Time Elapsed 00:00:00
@dawsontoth @Florimond I think we'll need to update our appveyor build for .NET Core. Otherwise it looks good, we could indeed rename it to SecurityAccess.
@Kelindar should I go ahead and rename it to SecurityAccess? I could leave the existing behind with a deprecation note. Or we could break people and force them to update. I've been using this change in my setup for the last month or so, and it's been working well. Any guidance on updating appveyor? Bit intimidated by it! :)
Go ahead with the rename. @florimond could you check the appveyor build?
Renamed. I left a lingering, empty EmitterKeyType with the Obsolete attribute explaining that SecurityAccess should be used instead.
No breaking changes were made, though several enum values were flagged as Obsolete. I copied over the full values and documentation from the Runtime for SecurityAccess.
Side question... should EmitterKeyType be named SecurityAccess?