emjun / tisane

Specification language for generating Generalized Linear Models (with or without mixed effects) from conceptual models
Apache License 2.0
21 stars 3 forks source link

Effect Set: Change to include Concepts, rather than Concept names? #9

Open emjun opened 3 years ago

emjun commented 3 years ago

As of Jan. 5, 2021, the Effect Set uses strings of Concept names (due to how we generate effects from the conceptual graph, and ultimately how we create nodes in the concept graph).

To make it easier/facilitate more seamless modeling from Effect Set (see model function in Tisane class), it may make more sense to use concepts, rather than strings?

emjun commented 3 years ago

Pro Concepts rather than just Concept names:

As of Jan. 11: The ASP constraint generation code hacks around the fact that Effect Sets provide only Concept Names (strs). This code will not cover edge cases where the variable names (in the dataset) are different from the concept names.