search

emk / heroku-buildpack-rust

A buildpack for Rust applications on Heroku, with full support for Rustup, cargo and build caching.
522 stars 186 forks source link

rustup uses stable at first deploy, ignoring RustConfig's $VERSION #16

Closed ghost closed 7 years ago

ghost commented 8 years ago

https://github.com/emk/heroku-buildpack-rust/blob/master/bin/compile#L86-L93

emk commented 8 years ago

Good catch! Thank you for finding this. Now lets see if I can remember the necessary rustup flags to fix it.

elifoster commented 8 years ago

--revision=$VERSION is how you specify a version.

ghost commented 8 years ago

--default-toolchain, i guess.

@elifoster --revision is for rustup.sh, not for rustup.rs.

emk commented 8 years ago

ack. Will look at this later.

Le 30 sept. 2016 5:18 PM, "tjikini" notifications@github.com a écrit :

--default-toolchain, i guess.

@elifoster https://github.com/elifoster --revision is for rustup.sh http://rust-lang/rustup.sh, not for rustup.rs http://rust-lang-nursery/rustup.rs.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/emk/heroku-buildpack-rust/issues/16#issuecomment-250854736, or mute the thread https://github.com/notifications/unsubscribe-auth/AACQY48dFUcA_tcaW1euzP2OjN0Rx7YHks5qvXyvgaJpZM4KHaTU .

emk commented 8 years ago

No, I switched it during the last round of updates I did, because it could self upgrade.

elifoster commented 8 years ago

Yeah I just noticed that. It gets named as rustup.sh which is what confused me.

emk commented 8 years ago

OK, just a reminder to myself that I want to fix this soon.