emk / heroku-buildpack-rust

A buildpack for Rust applications on Heroku, with full support for Rustup, cargo and build caching.
522 stars 186 forks source link

Add a flag to install the diesel CLI at build time #34

Closed gnmerritt closed 6 years ago

gnmerritt commented 6 years ago

This allows us to run diesel migrations during the release phase by shipping the diesel CLI along with the rest of your app.

sgrif commented 5 years ago

Out of curiosity, was there something that wasn't sufficiently solved by https://github.com/sgrif/heroku-buildpack-diesel ?

gnmerritt commented 5 years ago

Nope, just didn't happen to stumble across your build pack when I was looking for a solution. Thanks for the link!

sgrif commented 5 years ago

Would it be worth reverting this and just mentioning that buildpack in the README instead? It contains some additional things like version specifications and caching

gnmerritt commented 5 years ago

Imo it'd be bad to revert the change as people don't often point at a specific version of a buildpack (no sense breaking other folks builds) but updating the documentation makes sense to me.