search

emk / heroku-buildpack-rust

A buildpack for Rust applications on Heroku, with full support for Rustup, cargo and build caching.
522 stars 186 forks source link

Allow SSH into private GH repo #60

Closed hwsimmons17 closed 2 years ago

hwsimmons17 commented 2 years ago

This line is one copied from a PR I found 2 years ago that never was merged. It is really awesome as it allows this buildpack to talk with a private GH repo in conjunction with this buildpack: https://github.com/heroku/heroku-buildpack-ssh-key.git

emk commented 2 years ago

Thank you for the suggestion!

Is there a reason why this feature should be provided in this buildpack, and not by https://github.com/heroku/heroku-buildpack-ssh-key.git?

hwsimmons17 commented 2 years ago

Can you clarify, i.e. should it be added to the https://github.com/heroku/heroku-buildpack-ssh-key.git? This line of code got what I needed working, but if you think it would be better in the other repo, then you are right... I just know this worked

emk commented 2 years ago

Sure! I suspect that this setup is specific to how the other buildpack works, and as such, it probably shouldn't go into this buildpack. Unless I'm missing something here, which is always possible.

hwsimmons17 commented 2 years ago

I don't know hahaha, I just know those two lines of code saved me... I had been banging my head against the keyboard for 5 hours haha. I would love to see it added here, but if you think it is more general and needs to get added to the other repo then so be it, haha. I'm not an expert at dev ops/Heroku stuff... just was trying to solve a problem I had

emk commented 2 years ago

No problem! Good luck.

I haven't actually run this build pack in ages, because Heroku was more expensive for my current projects. I try to keep it working to avoid breaking other people's projects, but I'm very careful about adding new features!

hwsimmons17 commented 2 years ago

Ok, well if someone else is banging their head against the keyboard on this issue, I hope they see my PR and use it haha. But thank you!