Fix name of ghtoken binary in image

emk / rust-musl-builder

Docker images for compiling static Rust binaries using musl-libc and musl-gcc, with static versions of useful C libraries. Supports openssl and diesel crates.

Apache License 2.0

1.54k stars 193 forks source link

Fix name of ghtoken binary in image #103

Closed nhynes closed 2 years ago

nhynes commented 3 years ago

Renames ghtoken to the expected git-credential-ghtoken to resolve the following issue:

rust@1adcf00e7df0:~/src$ git clone https://github.com/myorg/private-repo
Cloning into 'private-repo'...
git: 'credential-ghtoken' is not a git command. See 'git --help'.

emk commented 3 years ago

Thank you for the PR! I'll hold this until the next release.

Roms1383 commented 3 years ago

could we please have a deadline for the next release ?

this commit is pending for over 6 months already (and requires us to derive our own image to include this fix)

emk commented 2 years ago

The next release is blocked on #126, because Docker Hub broke all my release automation. My apologies.

emk commented 2 years ago

I believe this should work again in the newest images. If anyone encounters this problem, please let me know.