emk / rust-musl-builder

Docker images for compiling static Rust binaries using musl-libc and musl-gcc, with static versions of useful C libraries. Supports openssl and diesel crates.
Apache License 2.0
1.54k stars 193 forks source link

[fix] always link zlib static #41

Closed bomgar closed 6 years ago

bomgar commented 6 years ago

libz-sys uses these options https://github.com/alexcrichton/libz-sys/blob/8eb6f9e8f45cef71f8a3fa94d849ac54a263c090/build.rs#L52

mriehl commented 6 years ago

Hey @bomgar @emk

I'll take care of encoding @bomgar 's test and travis config with cargo new, sed and echo semantics today.

imho this project is insanely useful for rust's ecosystem and accessibility, so if this is the price to pay to get this merged and improve the project, I'm glad to oblige. Your project your rules, yadda yadda.

That said, here's the things that are bugging me about this @emk - you don't need to respond to any of that, but I hope this helps clear things up why your request is seing so much pushback from @bomgar . These observation might or might not be accurate, it's just what I'm thinking.

That said these are just my thoughts. I'll stop that and take care of the test now ;)