search

emk / rust-musl-builder

Docker images for compiling static Rust binaries using musl-libc and musl-gcc, with static versions of useful C libraries. Supports openssl and diesel crates.
Apache License 2.0
1.54k stars 193 forks source link

replace deprecated openssl-sys by rust-openssl? #46

Closed dvic closed 6 years ago

dvic commented 6 years ago

I read on https://github.com/alexcrichton/openssl-sys that it's deprecated and that one should use https://github.com/sfackler/rust-openssl. Would rust-openssl work here?

emk commented 6 years ago

It's possible that it might already work!

If it doesn't, we really ought to support it. But updating new libraries can be a pretty time-consuming process. And in any case, we can't stop supporting openssl-sys, because I'm sure plenty of people are still using it.

If anybody wants to look into this, I'm happy to answer questions. I probably won't be able to get to it right away myself.

dvic commented 6 years ago

Fixed in #48

emk commented 6 years ago

Thank you for the patches! I merged them and updated the README, and they should be building now.