emk
commented
5 years ago Thank you! I've confirmed this bug still exists after all known workarounds are applied. I'll take a shot at it tomorrow.
Open chrisabruce opened 5 years ago
emk
commented
5 years ago Thank you! I've confirmed this bug still exists after all known workarounds are applied. I'll take a shot at it tomorrow.
emk
commented
5 years ago OK, I've spent the last several hours updating everything to the latest dependencies, and I can still reproduce this bug.
Here's a few things I've observed so far:
libpq_sys linking to OpenSSL...at least as far as I can tell. Here's a sample:
= note: /home/rust/src/target/x86_64-unknown-linux-musl/release/deps/libpq_sys-3a6911426f910838.rlib(fe-secure-openssl.o): In function `SSLerrmessage':
fe-secure-openssl.c:(.text+0x39): undefined reference to `ERR_reason_error_string'This is interesting because libpq actually tries to link to openssl at the C level, but not (necessarily?) at the Rust level. I need to investigate this.
This:
/home/rust/src/target/x86_64-unknown-linux-musl/release/deps/libopenssl_sys-4783752d3593d472.rlib...appears before:
"/home/rust/src/target/x86_64-unknown-linux-musl/release/deps/libpq_sys-3a6911426f910838.rlib"IIRC correctly, this means that libpq won't be able to access libopenssl, because symbols in a library can only be looked up in libraries that come after.
extern crate opensslThis suggests that libpq isn't correctly managing to link to OpenSSL by itself.
rust-musl-builder for a number of other projects...and some of those projects have been updated or created very recently. So at least some of the time, this does work.
Taken together, this suggests that that problem might be that libpq isn't correctly declaring a dependency on libopenssl
Things to try:
libopenssl-sys, and get it to work?build.rs script for libpq do?libpq-sys bug tracker that looks relevant?emk
commented
5 years ago OK, so I have verified that:
using-diesel in debug mode Just Works.using-diesel to link in release mode if I reorder the libraries we're linking against.So this sounds like a case of libpq not correctly pulling in its dependencies, as hypothesized. On to the next step...
emk
commented
5 years ago libpq's build.rs is here: https://github.com/sgrif/pq-sys/blob/master/build.rs
It doesn't do anything in particular to ensure that OpenSSL, etc., get linked in. And none of the bugs in the bug tracker look relevant.
So now I want to look at the other, similar Rust images that statically link libpq, and see if anybody else has an existing fix for this.
emk
commented
5 years ago As mentioned in #64, it may be possible to force correct linking using:
extern crate openssl;
#[macro_use]
extern crate diesel;Other cross builders:
muslrust has a bug that looks suspiciously similar: https://github.com/clux/muslrust/issues/49rusl-musl-cross doesn't appear to have any Diesel-related examples or Diesel-related bugs, so I can't tell whether they've ever encountered or fixed this problem.So there's no obvious, existing solution in any other Rust static builders.
Next steps:
experimental and experimental-2019-04-12.pq-sys describing what's we've found, so that we discuss a possible upstream solution to remove the need for this workaround.emk
commented
5 years ago Issue filed upstream: https://github.com/sgrif/pq-sys/issues/25
iddm
commented
5 years ago Would you mind notifying watchers of this issue when the problem is solved? I am really concerned.
emk
commented
5 years ago @vityafx Please try the workaround mentioned above:
// Order matters!
extern crate openssl;
#[macro_use]
extern crate diesel;This should work for most current versions of Rust.
iddm
commented
5 years ago It worked for me but I think importing openssl crate when I don't need it is a bit weird, especially breaking the order of the imports.
onelson
commented
5 years ago The deliberately ordered extern crate workaround worked for me on one project, but didn't on another. After a couple hours of disbelief, I shrugged my shoulders and just ran cargo update, which was apparently all I needed to do. I'm not sure which crate was the offensive one, but included in the bumps were openssl 0.10.21 -> 0.10.22, and openssl-sys 0.9.44 -> 0.9.46.
Not sure who needs to hear this, but just in case anyone else gets stuck... give cargo update a shot.
emk
commented
5 years ago We're going to need somebody to submit a PR for sgrif/pq-sys#25. I'm extremely busy on another project right now and won't be able to tackle this for a couple of weeks. Please feel free to ping me at the end of July or early August.
iddm
commented
5 years ago Can I use this hack still on the rust 2018 edition?
iddm
commented
5 years ago I have asked the question about rust 2018 because it does not work in it. The hack with extern crate order. cargo update also does not help.
UPD: It worked again suddenly. I don't know why.
iddm
commented
5 years ago = note: /home/rust/src/target/x86_64-unknown-linux-musl/debug/deps/libpq_sys-f2ec40b7c53867fb.rlib(fe-connect.o): In function `parseServiceFile':
(.text+0xbd1): undefined reference to `ldap_init'
(.text+0xbf1): undefined reference to `ldap_set_option'
(.text+0xc05): undefined reference to `ldap_simple_bind'
(.text+0xc39): undefined reference to `ldap_result'
(.text+0xc57): undefined reference to `ldap_msgfree'
(.text+0xc76): undefined reference to `ldap_set_option'
(.text+0xcb4): undefined reference to `ldap_search_st'
(.text+0xcda): undefined reference to `ldap_msgfree'
(.text+0xce9): undefined reference to `ldap_err2string'
(.text+0xd14): undefined reference to `ldap_unbind'
(.text+0x1001): undefined reference to `ldap_unbind'
(.text+0x101c): undefined reference to `ldap_count_entries'
(.text+0x1055): undefined reference to `ldap_msgfree'
(.text+0x105d): undefined reference to `ldap_unbind'
(.text+0x1093): undefined reference to `ldap_first_entry'
(.text+0x10b8): undefined reference to `ldap_get_values_len'
(.text+0x10e1): undefined reference to `ldap_msgfree'
(.text+0x11ac): undefined reference to `ldap_value_free_len'
(.text+0x11b7): undefined reference to `ldap_unbind'
(.text+0x124d): undefined reference to `ldap_msgfree'
(.text+0x125d): undefined reference to `ldap_unbind'
(.text+0x1287): undefined reference to `ldap_value_free_len'
(.text+0x128f): undefined reference to `ldap_unbind'
/home/rust/src/target/x86_64-unknown-linux-musl/debug/deps/libpq_sys-f2ec40b7c53867fb.rlib(fe-connect.o): In function `default_threadlock':
(.text+0x1a79): undefined reference to `__fprintf_chk'
/home/rust/src/target/x86_64-unknown-linux-musl/debug/deps/libpq_sys-f2ec40b7c53867fb.rlib(fe-connect.o): In function `pqDropConnection':
(.text+0x208b): undefined reference to `gss_delete_sec_context'
(.text+0x20a5): undefined reference to `gss_release_name'
/home/rust/src/target/x86_64-unknown-linux-musl/debug/deps/libpq_sys-f2ec40b7c53867fb.rlib(fe-connect.o): In function `PQconnectPoll':
(.text+0x28dc): undefined reference to `__snprintf_chk'
(.text+0x2955): undefined reference to `__snprintf_chk'
/home/rust/src/target/x86_64-unknown-linux-musl/debug/deps/libpq_sys-f2ec40b7c53867fb.rlib(fe-connect.o): In function `PQsetClientEncoding':
(.text+0x48fb): undefined reference to `__sprintf_chk'
/home/rust/src/target/x86_64-unknown-linux-musl/debug/deps/libpq_sys-f2ec40b7c53867fb.rlib(fe-connect.o): In function `parseServiceInfo':
(.text+0x4c8a): undefined reference to `__snprintf_chk'
(.text+0x4d15): undefined reference to `__snprintf_chk'
/home/rust/src/target/x86_64-unknown-linux-musl/debug/deps/libpq_sys-f2ec40b7c53867fb.rlib(fe-connect.o): In function `connectOptions2':
(.text+0x6468): undefined reference to `__snprintf_chk'
(.text+0x67a0): undefined reference to `__fprintf_chk'
/home/rust/src/target/x86_64-unknown-linux-musl/debug/deps/libpq_sys-f2ec40b7c53867fb.rlib(fe-exec.o): In function `pqInternalNotice':
(.text+0x128f): undefined reference to `__vsnprintf_chk'
(.text+0x1379): undefined reference to `__sprintf_chk'
/home/rust/src/target/x86_64-unknown-linux-musl/debug/deps/libpq_sys-f2ec40b7c53867fb.rlib(fe-exec.o): In function `PQcopyResult':
(.text+0x1677): undefined reference to `__strcpy_chk'
/home/rust/src/target/x86_64-unknown-linux-musl/debug/deps/libpq_sys-f2ec40b7c53867fb.rlib(fe-exec.o): In function `pqSaveParameterStatus':
(.text+0x18e8): undefined reference to `__fprintf_chk'
/home/rust/src/target/x86_64-unknown-linux-musl/debug/deps/libpq_sys-f2ec40b7c53867fb.rlib(fe-exec.o): In function `PQoidStatus':
(.text+0x3c86): undefined reference to `__memcpy_chk'
/home/rust/src/target/x86_64-unknown-linux-musl/debug/deps/libpq_sys-f2ec40b7c53867fb.rlib(fe-misc.o): In function `pqGets_internal':
(.text+0xc7): undefined reference to `__fprintf_chk'
/home/rust/src/target/x86_64-unknown-linux-musl/debug/deps/libpq_sys-f2ec40b7c53867fb.rlib(fe-misc.o): In function `pqGetc':
(.text+0x19b): undefined reference to `__fprintf_chk'
/home/rust/src/target/x86_64-unknown-linux-musl/debug/deps/libpq_sys-f2ec40b7c53867fb.rlib(fe-misc.o): In function `pqGetnchar':
(.text+0x242): undefined reference to `__fprintf_chk'
/home/rust/src/target/x86_64-unknown-linux-musl/debug/deps/libpq_sys-f2ec40b7c53867fb.rlib(fe-misc.o): In function `pqSkipnchar':
(.text+0x2ee): undefined reference to `__fprintf_chk'
/home/rust/src/target/x86_64-unknown-linux-musl/debug/deps/libpq_sys-f2ec40b7c53867fb.rlib(fe-misc.o): In function `pqGetInt':
(.text+0x3da): undefined reference to `__fprintf_chk'
/home/rust/src/target/x86_64-unknown-linux-musl/debug/deps/libpq_sys-f2ec40b7c53867fb.rlib(fe-misc.o):(.text+0x619): more undefined references to `__fprintf_chk' follow
/home/rust/src/target/x86_64-unknown-linux-musl/debug/deps/libpq_sys-f2ec40b7c53867fb.rlib(fe-protocol2.o): In function `pqSetenvPoll':
(.text+0xb24): undefined reference to `__sprintf_chk'
(.text+0xc4a): undefined reference to `__sprintf_chk'
(.text+0xcd2): undefined reference to `__sprintf_chk'
/home/rust/src/target/x86_64-unknown-linux-musl/debug/deps/libpq_sys-f2ec40b7c53867fb.rlib(pqexpbuffer.o): In function `appendPQExpBufferVA':
(.text+0x265): undefined reference to `__vsnprintf_chk'
/home/rust/src/target/x86_64-unknown-linux-musl/debug/deps/libpq_sys-f2ec40b7c53867fb.rlib(chklocale.o): In function `pg_get_encoding_from_locale':
(.text+0x1ff): undefined reference to `__fprintf_chk'
/home/rust/src/target/x86_64-unknown-linux-musl/debug/deps/libpq_sys-f2ec40b7c53867fb.rlib(inet_net_ntop.o): In function `inet_net_ntop':
(.text+0xdc): undefined reference to `__sprintf_chk'
(.text+0x2d2): undefined reference to `__sprintf_chk'
(.text+0x337): undefined reference to `__sprintf_chk'
(.text+0x3b8): undefined reference to `__sprintf_chk'
(.text+0x478): undefined reference to `__sprintf_chk'
/home/rust/src/target/x86_64-unknown-linux-musl/debug/deps/libpq_sys-f2ec40b7c53867fb.rlib(inet_net_ntop.o):(.text+0x4b7): more undefined references to `__sprintf_chk' follow
/home/rust/src/target/x86_64-unknown-linux-musl/debug/deps/libpq_sys-f2ec40b7c53867fb.rlib(ip.o): In function `pg_getaddrinfo_all':
(.text+0x170): undefined reference to `__strcpy_chk'
/home/rust/src/target/x86_64-unknown-linux-musl/debug/deps/libpq_sys-f2ec40b7c53867fb.rlib(fe-secure-openssl.o): In function `SSLerrmessage':
(.text+0x84): undefined reference to `__snprintf_chk'
(.text+0xb7): undefined reference to `__snprintf_chk'
/home/rust/src/target/x86_64-unknown-linux-musl/debug/deps/libpq_sys-f2ec40b7c53867fb.rlib(fe-secure-openssl.o): In function `initialize_SSL':
(.text+0x4de): undefined reference to `__snprintf_chk'
(.text+0x5ee): undefined reference to `__snprintf_chk'
(.text+0x6b6): undefined reference to `__snprintf_chk'
/home/rust/src/target/x86_64-unknown-linux-musl/debug/deps/libpq_sys-f2ec40b7c53867fb.rlib(fe-secure-openssl.o):(.text+0x963): more undefined references to `__snprintf_chk' follow
/home/rust/src/target/x86_64-unknown-linux-musl/debug/deps/libpq_sys-f2ec40b7c53867fb.rlib(fe-auth.o): In function `pg_GSS_error_int':
(.text+0x5b): undefined reference to `gss_display_status'
(.text+0x7e): undefined reference to `gss_release_buffer'
/home/rust/src/target/x86_64-unknown-linux-musl/debug/deps/libpq_sys-f2ec40b7c53867fb.rlib(fe-auth.o): In function `pg_GSS_continue':
(.text+0x15b): undefined reference to `gss_init_sec_context'
(.text+0x188): undefined reference to `gss_release_buffer'
(.text+0x1eb): undefined reference to `gss_release_buffer'
(.text+0x270): undefined reference to `gss_release_name'
(.text+0x28b): undefined reference to `gss_delete_sec_context'
(.text+0x2a3): undefined reference to `gss_release_name'
/home/rust/src/target/x86_64-unknown-linux-musl/debug/deps/libpq_sys-f2ec40b7c53867fb.rlib(fe-auth.o): In function `pg_fe_sendauth':
(.text+0x531): undefined reference to `__snprintf_chk'
(.text+0x545): undefined reference to `GSS_C_NT_HOSTBASED_SERVICE'
(.text+0x55c): undefined reference to `gss_import_name'
/home/rust/src/target/x86_64-unknown-linux-musl/debug/deps/libpq_sys-f2ec40b7c53867fb.rlib(fe-auth.o): In function `PQencryptPasswordConn':
(.text+0xf34): undefined reference to `__memcpy_chk'
/home/rust/src/target/x86_64-unknown-linux-musl/debug/deps/libpq_sys-f2ec40b7c53867fb.rlib(fe-auth-scram.o): In function `pg_fe_scram_exchange':
(.text+0x5c6): undefined reference to `__snprintf_chk'
/home/rust/src/target/x86_64-unknown-linux-musl/debug/deps/libpq_sys-f2ec40b7c53867fb.rlib(scram-common.o): In function `scram_build_verifier':
(.text+0x5a4): undefined reference to `__sprintf_chk'
collect2: error: ld returned 1 exit status
error: aborting due to previous errorThis thing does not let me sleep normally.
emk
commented
4 years ago I haven't seen any new reports of this error in a while, so maybe the upstream fixes all went through. If you're still seeing problems on the most recent versions of everything, please feel free to reopen this issue.
Thank you to everybody who has found workarounds or fixes for this issue!
Raniz85
commented
4 years ago Just a note that if you have multiple binaries in your project you need to put the extern crate declarations at the top of all of them.
alertedsnake
commented
4 years ago I'm still having this issue and no combination of any of the suggestions I've found work. Are there any new suggestions?
Edit: actually nevermind - I forgot I had a main.rs and a lib.rs which it imports (there are multiple binaries, though I'm only building one). It's working with the proper ordering of the extern crate statements. So thanks for the help!
adwhit
commented
3 years ago This bug could be related to https://github.com/rust-lang/rust/issues/61328 (which has bitten me multiple times). It seems to be something to do with the order in which linker inputs are declared - the above workaround presumably changes the declaration order of linker libs which somehow fixes it.
Trying to build with the
using-dieselexample fails. Here is snippet of error: