emk / rust-musl-builder

Docker images for compiling static Rust binaries using musl-libc and musl-gcc, with static versions of useful C libraries. Supports openssl and diesel crates.
Apache License 2.0
1.54k stars 193 forks source link

Is README out of date for nightly tags? #79

Closed sentient-abanchich closed 5 years ago

sentient-abanchich commented 5 years ago

Running with a date in the tag does not work for me:

docker run --rm -it -v "$(pwd)":/home/rust/src -v cargo-git:/home/rust/.cargo/git -v cargo-registry:/home/rust/.cargo/registry -v target:/home/rust/src/target ekidd/rust-musl-builder:nightly-2019.08.01

Unable to find image 'ekidd/rust-musl-builder:nightly-2019.08.01' locally
docker: Error response from daemon: manifest for ekidd/rust-musl-builder:nightly-2019.08.01 not found: manifest unknown: manifest unknown.
See 'docker run --help'.

Running this without a date in the tag (not show in the README) does work:

docker run --rm -it -v "$(pwd)":/home/rust/src -v cargo-git:/home/rust/.cargo/git -v cargo-registry:/home/rust/.cargo/registry -v target:/home/rust/src/target ekidd/rust-musl-builder:nightly
sentient-abanchich commented 5 years ago

Also wondering about the Making OpenSSL work section of the README. I am using reqwest in my crate and hitting https endpoints but I didn't have to do anything with openssl_probe; it just worked.

emk commented 5 years ago

My policy for nightly images has changed a bit:

If there's a specific newer nightly image that you'd like a tagged build for, please feel free to file an issue.

Also wondering about the Making OpenSSL work section of the README. I am using reqwest in my crate and hitting https endpoints but I didn't have to do anything with openssl_probe; it just worked.

Generally speaking, if you don't include openssl_probe, your static binaries will fail on various Linux distros.

sentient-abanchich commented 5 years ago

Ah, that explains it! I was using the nightly-2019-08-01 syntax too but just needed the list of Docker tags.

Thanks!