Ensure "ghtoken" is available in "$PATH"

emk / rust-musl-builder

Docker images for compiling static Rust binaries using musl-libc and musl-gcc, with static versions of useful C libraries. Supports openssl and diesel crates.

Apache License 2.0

1.54k stars 193 forks source link

Ensure "ghtoken" is available in "$PATH" #89

Closed zacatac closed 4 years ago

zacatac commented 4 years ago

I was running into some trouble downloading crates from private repositories. I believe the culprit is that the credential helper ghtoken isn't available in the $PATH.

zacatac commented 4 years ago

Just confirming the fix now. Will mark as ready to review soon.

zacatac commented 4 years ago

@emk I'm going to close this so it isn't sitting stale, but feel free to reopen!

emk commented 4 years ago

Thank you for the fix! Please don't close PRs so quickly, though. :-)

I have a ton of different open source projects that I maintain, and I get back around to rust-musl-builder every 6 weeks or so when a new stable Rust is released. My apologies for the slow turnaround time, and my thanks for the fix.