search

emk / subtitles-rs

Use SRT subtitle files to study foreign languages (in progress)
Apache License 2.0
303 stars 34 forks source link

Preserve line breaks in multiline subtitles #12

Open Arthaey opened 7 years ago

emk commented 7 years ago

This is an interesting idea, but it tends to produce weird-looking output in two important modes:

  1. When generating bilingual *.srt files, which need to conserve vertical real estate on the TV screen.
  2. When there isn't a simple 1-to-1 mapping between the two languages' subs, and multiple subtitles need to be merged. This works much better if I join lines across the merged subs.
Arthaey commented 7 years ago

How would you feel if I submitted a (tested) patch for adding a manual control, something like --multiline?

aaron-meyers commented 4 months ago

Please consider this in conjunction with #59. I've been using your tool as part of a script that produces EPUBs for offline study of subtitled content and would love to preserve line breaks to improve the formatting.

Would also love to see support for overlapping subtitles - this has been on my list to figure out but would be great if substudy just supported it directly. Sounds like you're at least thinking about it per #37.

Thanks for your great tool!

emk commented 4 months ago

I've been using your tool as part of a script that produces EPUBs for offline study of subtitled content and would love to preserve line breaks to improve the formatting.

Oh, cool! I've started a discussion of the new file format at https://github.com/emk/subtitles-rs/issues/59#issuecomment-2094363029, and I'd love your feedback on supporting your ebook exporter.

emk commented 4 months ago

I've also started a discussion about how to handle overlapping subs at #60.