search

emk / subtitles-rs

Use SRT subtitle files to study foreign languages (in progress)
Apache License 2.0
304 stars 32 forks source link

Option to include an extra line of dialog before or after #13

Closed Arthaey closed 7 years ago

Arthaey commented 7 years ago

The automatic splitting seems pretty decent, but sometimes it chops a sentence awkwardly. It would be nice if I could ask substudy to include one line of dialog before or after the "target" line for context.

Ideally, as separate "columns" in the csv output, so I can style them differently in Anki. :)

emk commented 7 years ago

Thank you for the suggestion!

I'm always reluctant to add flags and options. If you can convincingly argue that the current default behavior is wrong, we can definitely change the defaults! :-) But adding a flag is a bigger deal than changing a default as far as I'm concerned.

(Also, if your subtitles are very messy, I do encourage the use of a tool like Subtitle Edit or the Mac equivalent to clean them up. substudy is not really a great tool for that job. And it's anticipated that a certain small percentage of cards may be useless.)

Arthaey commented 7 years ago

My subs in this case aren't messy, I just want a little context on my cards. :)

I hear you on the drawbacks of "just add an option!" for every little thing. It definitely is a balance.

If I were to argue for always including the context lines, I'd say that they can be easily ignored when importing the csv, but they can't be easily recreated if they don't already exist.

Arthaey commented 7 years ago

Wait a minute... I somehow imported the csv into Anki thinking that there weren't context lines... but they totally already exist! :blush:

emk commented 7 years ago

Ah, OK! I figured that one context line on either side and (IIRC) 1.5 seconds of audio on either side worked out well across a wide range of cards, but that I didn't want to add any more.