search

emk / subtitles-rs

Use SRT subtitle files to study foreign languages (in progress)
Apache License 2.0
304 stars 32 forks source link

common_failures - diffferent expectation #40

Closed drahnr closed 6 months ago

drahnr commented 6 years ago

Given that error-chains quick-error presents the whole chain of failure causes, I expected this to be the same for common_failures but it only displays the top level error cause.

There was a ticket for failure showing various approaches: https://github.com/rust-lang-nursery/failure/issues/76

emk commented 6 years ago

As you can see here, the quick_error! macro calls display_causes_and_backtrace, which in turn loops over and displays all causes.

Could you please provide some more detail about what you're seeing here? What happens if you manually print the cause of your error?

drahnr commented 6 years ago

I'll double check, but I am pretty positive the result - given I provided context - was only one level deep. Verifying version too.

emk commented 6 months ago

The common_failures crate has been deprecated, because failure has been deprecated. Sorry we never figured this out!