Fix encoding issues for utf-16

emkor / napi-py

CLI tool for downloading subtitles from napiprojekt.pl

GNU General Public License v3.0

7 stars 2 forks source link

Fix encoding issues for utf-16 #3

Closed steciuk closed 3 months ago

steciuk commented 3 months ago

I was happily using your lib (thanks!), but run into some issues with subs encoding. After some tests, it looked like it usually has problems with utf-16.

I quickly duct-taped a solution (cbba6a8b4b9cc7693d387561e9fa6ea36aee5a63),
and added chardet auto encoding detection just to be sure (4b5009e2749107f424491bfee6a1ee0a4e1733c6).

I've never used Poetry or published a python package, so I would be glad If you could properly complete this PR and hopefully update napi-py <3.

emkor commented 3 months ago

Thanks for activity on the project and fixing the issue, will review sometime next week as I'm pretty busy right now

steciuk commented 3 months ago

Sure! I've decided to watch some Poetry 101 on YT and updated the deps to make it easier on you. When you have some time to review, please let me know if there is anything else that should be done.

emkor commented 3 months ago

Newest version has been released to pypi https://pypi.org/project/napi-py/1.2.3/ thanks for contributing