search

emmVRC / emmVRC-Public

Public page for the emmVRC mod
30 stars 8 forks source link

[BUG] Avatar Favorites list increases CPU load and frametime after it's been closed #1430

Closed TieDyeTopHat closed 3 years ago

TieDyeTopHat commented 3 years ago

Expected: CPU frametime returning to normal after opening avatar list(without melonloader and emm, this is what it does) 2021-03-25-PM_03_53_47 Actual behavior: CPU load and frametime rise and continue to stay high after the favorites menu has been closed. Disabling the favorites list makes a noticeable change to frametime, but it still remains higher than normal. 2021-03-25-PM_03_55_16 2021-03-25-PM_03_55_55 Measured using Desktop+ 2.4 performance graph

Steps to reproduce: Load vrchat, open avatar menu, close avatar menu.

MintLily commented 3 years ago

I'm not trying to say this is specifically an emmVRC issue, but frame time can vary just from the number of elements being rendered. Like some of the following: individual objects (in a world), amount of UI elements, number of avatars, number of separated meshes on avatars, etc. The list can go on forever. Basically, the more elements being rendered, the more likely your (or anyone's) frame time will increase. This doesn't necessarily just apply to VRChat, any game takes this into account when being developed. I think your issue is this: Because emmVRC is copying and pasting an already made VRChat avatar list, a quite a bit extra elements are being rendered (even "off-screen"). There's not much we can do, but we will look into this to try and further optimize the Avatar List in every way we can.

thetrueyoshifan commented 3 years ago

Should be improved with emmVRC v2.8.0. If it's still an issue, let me know.