search

emmanuelparadis / ape

analysis of phylogenetics and evolution
http://ape-package.ird.fr/
GNU General Public License v2.0
52 stars 11 forks source link

Warn if node labels mismatched #115

Closed ms609 closed 5 months ago

ms609 commented 5 months ago

Resolves #113

stitam commented 5 months ago

Many thanks @ms609. I am wondering if warning() is strong enough, I would probably fix an inconsistent phylo object before going further, just to be safe. Do you think stop() would be too much?

ms609 commented 5 months ago

I went for warning() because there's no absolute necessity to abort – a user may have some obscure and unanticipated reason for wishing to override the sanity check and proceed with mismatched labels.

emmanuelparadis commented 5 months ago

Many thanks for this. Now merged and pushed a new version here with updated files. Almost ready to submit v. 5.8 to CRAN!