Closed maelle closed 1 year ago
Or alternatively, I'd be happy to make a PR removing the native pipe if that were your preferred option.
Hi Maëlle, In your specific case, I think changing the code to make it work with older versions of R is the best solution.
More generally, I think it's a good idea to have some flexibilify with respect to the version of R. For instance, see the recent issue (#67); it's not always possible to easily upgrade your OS and/or R.
If a special recent feature from R or from another package is needed for some code, but not indispensable in general, this can be tested with R.Version()
or packageVersion()
.
Best, Emmanuel
Awesome, merci @emmanuelparadis! I updated my PR :slightly_smiling_face: I agree it's not always easy to upgrade R so this is a nicer change for users.
I linked this PR to #67 so merging this would close it.
Thank you! Merged and I increased the version number to distinguish with the CRAN version.
Thank you for being so responsive :pray:
By the way, relatedly, I see ape has a Suggests dependency on phangorn, which is a package that has a dependency on R 4.1.0 because of the native pipe (so your R CMD check workflow on R < 4.1.0 fails).
Last comment/question, is there any expected date for a new CRAN submission of ape?
By the way, relatedly, I see ape has a Suggests dependency on phangorn, which is a package that has a dependency on R 4.1.0 because of the native pipe (so your R CMD check workflow on R < 4.1.0 fails).
Correct. The check fails but ape 5.7 should still be able to be installed and used with R < 4.1.0.
On CRAN, "oldrelease" is R 4.1.3.
Last comment/question, is there any expected date for a new CRAN submission of ape?
I usually upgrade ape on CRAN once in a year, but sometimes if there is a strong need, this can be done in a shorter time.
I greatly appreciate your help! It would help the igraph project if you could send an out-of-order update of ape to CRAN. The release should go smoothly if there are not too many changes.
I've submitted ape 5.7-1 to CRAN. Cheers!
Thanks. CRAN still has ape 5.7, did the release get through?
Still processing. Im fixing some details.
congrats on getting the new version on CRAN, and thanks a lot!
Fix #67
:wave: here, thanks for your work on {ape}!
In https://github.com/emmanuelparadis/ape/blob/0031c04bcafc9b9e387829c9b6441c9fc4ff008d/R/rtt.R#L37 the native pipe is used, so in practice {ape} should depend on R >= 4.1.0. :smile_cat: