search

emmanuelrosa / erosanix

My main NixOS/Nix Flakes repository
MIT License
88 stars 5 forks source link

mkWindowsApp lock to prevent multiple `winAppInstall` launches #22

Open crabdancing opened 1 month ago

crabdancing commented 1 month ago

If you set up a GUI icon, a lot of users will have the instinct to try to open it again if it seems slow. This results in potentially multiple installer phase instances being launched at the same time. Having some sort of file lock set during winAppInstall would prevent this. While it's certainly possible to set this up outside of mkWindowsApp, the fact that it's useful across all mkWindowsApp packages means that it would make sense to add this feature to mkWindowsApp itself.

emmanuelrosa commented 1 month ago

Firstly, thank you for reporting your insights.

I developed the initial version of mkWindowsApp about 2 years ago, and it's only recently that I've noticed others have started to use it. Naturally, this means bugs will be discovered now :)

I'll take a look at this, and the other issue you reported.

Currently, there's a sort-of locking mechanism but it only takes effect after a complete installation. All it does is skip certain steps, so it's not a lock in the sense you've described.

crabdancing commented 1 month ago

Awesome, thank you! :D

My partner uses a lot of Windows-only 3D modeling apps, and mkWindowsApp was super useful for packaging them in a reliable way. Thanks for making it! :3