search

emmanueltouzery / prelude-ts

Functional programming, immutable collections and FP constructs for typescript and javascript
ISC License
377 stars 21 forks source link

Consider better naming. #18

Closed MartynasZilinskas closed 6 years ago

MartynasZilinskas commented 6 years ago

In my opinion it's really odd package naming. It can be easily mistaken with file name. I would recommend using ts-prelude.

I am aware that there are other projects with odd naming like: https://www.npmjs.com/package/lazy.js

Other examples that using my proposed naming: https://www.npmjs.com/package/ts-promise https://www.npmjs.com/package/ts-httpexceptions https://www.npmjs.com/package/probot-ts

Let me know what do you think.

emmanueltouzery commented 6 years ago

If it doesn't cause specific issues I'm ok with it being odd. There is also immutable.js (though the npm package is "immutable"), and many of these I think. It doesn't concern me at this point.

I wouldn't change it just for esthetic reasons at this point.

emmanueltouzery commented 6 years ago

by the way I did get confirmation from the typescript authors that technically the package name is OK https://github.com/Microsoft/TypeScript/issues/20603

MartynasZilinskas commented 6 years ago

No worries, I suggested for a better naming. Only because files ends with extension .ts.