search

emmanueltouzery / prelude-ts

Functional programming, immutable collections and FP constructs for typescript and javascript
ISC License
377 stars 21 forks source link

Enable usage as an npm github dependency #63

Closed malcolmredheron closed 1 year ago

malcolmredheron commented 2 years ago

That is, with this we can add the github repo as a dependency without packagining and pushing to npm.

The changes are based on https://stackoverflow.com/questions/40528053/npm-install-and-build-of-forked-github-repo/57829251#57829251

emmanueltouzery commented 1 year ago

thank you!

malcolmredheron commented 1 year ago

Thanks for taking this! Out of interest, did you squash my branch when you merged? The commit has a different hash in your repo (5df18a) and in mine (dd02f2), so I still need to rebase my other branches to clean this up. If you think that I did something wrong, perhaps when I made the pull request, I'd love feedback.

emmanueltouzery commented 1 year ago

i just picked the default github option, i didn't pay attention, since the PR had a single commit anyway. i think it's expected the hash would be different, not too sure.

malcolmredheron commented 1 year ago

Ok. No problem. I've sent you another small one that changes how exceptions are thrown and will get you a few more soon.

On Mon, Sep 26, 2022 at 12:21 PM, emmanueltouzery < @.*** > wrote:

i just picked the default github option, i didn't pay attention, since the PR had a single commit anyway. i think it's expected the hash would be different, not too sure.

— Reply to this email directly, view it on GitHub ( https://github.com/emmanueltouzery/prelude-ts/pull/63#issuecomment-1258507707 ) , or unsubscribe ( https://github.com/notifications/unsubscribe-auth/AAAOIXJGDQDIP25A3ZTUB53WAHZVHANCNFSM6AAAAAAQNVAQSQ ). You are receiving this because you authored the thread. Message ID: <emmanueltouzery/prelude-ts/pull/63/c1258507707 @ github. com>